Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1144593002: Revert of [Chromoting] Show any startup errors in the LoadingWindow. (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
Reviewers:
Jamie, garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromoting] Show any startup errors in the LoadingWindow. (patchset #5 id:80001 of https://codereview.chromium.org/1139543002/) Reason for revert: Syntax error in the JS, breaking the closure bot and almost surely doesn't work well/breaking something in remoting. http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/22330/steps/compile/logs/stdio Original issue's description: > [Chromoting] Show any startup errors in the LoadingWindow. > > Show any connection errors during startup in the LoadingWindow rather > than creating a new error window for the error. > > This cl also adds a new updateErrorMessage method to the MessageWindow > to update the message and reset the message window as appropriate for > an error message (disabling the spinner, updating the button label). > > BUG= > > Committed: https://crrev.com/d44e8a774ce99a89c350d10d5b3f9f644eb0c3d1 > Cr-Commit-Position: refs/heads/master@{#330022} TBR=jamiewalch@chromium.org,garykac@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b9c8f8119517a50c155dba814477ae5319da5174 Cr-Commit-Position: refs/heads/master@{#330052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -129 lines) Patch
M remoting/webapp/app_remoting/js/app_remoting_activity.js View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/webapp/base/js/message_window.js View 2 chunks +76 lines, -76 lines 0 comments Download
M remoting/webapp/base/js/message_window_helper.js View 2 chunks +1 line, -28 lines 0 comments Download
M remoting/webapp/base/js/typecheck.js View 3 chunks +10 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of [Chromoting] Show any startup errors in the LoadingWindow.
5 years, 7 months ago (2015-05-15 06:20:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144593002/1
5 years, 7 months ago (2015-05-15 06:20:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 06:21:11 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 06:21:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9c8f8119517a50c155dba814477ae5319da5174
Cr-Commit-Position: refs/heads/master@{#330052}

Powered by Google App Engine
This is Rietveld 408576698