Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: remoting/webapp/base/js/message_window_helper.js

Issue 1144593002: Revert of [Chromoting] Show any startup errors in the LoadingWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/base/js/message_window.js ('k') | remoting/webapp/base/js/typecheck.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/base/js/message_window_helper.js
diff --git a/remoting/webapp/base/js/message_window_helper.js b/remoting/webapp/base/js/message_window_helper.js
index ffcdc23a16ef9989e8e597cc46537bac32f53946..f6657577c4982894d44f22afa5bd43c2f5e1ea22 100644
--- a/remoting/webapp/base/js/message_window_helper.js
+++ b/remoting/webapp/base/js/message_window_helper.js
@@ -41,9 +41,6 @@
/** @type {number} */
this.minimumWidth = 0;
-
- /** @type {boolean} */
- this.showSpinner = false;
};
/**
@@ -154,32 +151,8 @@
}
var message_struct = {
- command: 'update',
+ command: 'update_message',
message: message
- };
- this.window_.postMessage(message_struct, '*');
-};
-
-/**
- * Update the message being shown in the window to the given error message.
- * In addition to updating the message, any spinner is disabled and the
- * button text is changed to 'OK'.
- * This should only be called after the window has been shown.
- *
- * @param {string} message The message.
- */
-remoting.MessageWindow.prototype.updateErrorMessage = function(message) {
- if (!this.window_) {
- this.pendingWindowOperations_.push(this.updateMessage.bind(this, message));
- return;
- }
-
- var message_struct = {
- command: 'update',
- message: message,
- buttonLabel: chrome.i18n.getMessage(/*i18n-content*/'OK'),
- cancelButtonLabel: '',
- showSpinner: false
};
this.window_.postMessage(message_struct, '*');
};
« no previous file with comments | « remoting/webapp/base/js/message_window.js ('k') | remoting/webapp/base/js/typecheck.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698