Sync user's custom spellcheck dictionary

chrome/browser/spellchecker/spellcheck_service.h

Index: chrome/browser/spellchecker/spellcheck_service.h
diff --git a/chrome/browser/spellchecker/spellcheck_service.h b/chrome/browser/spellchecker/spellcheck_service.h
index 77756e455a4e933b0ab2582536b57d51269687ca..10f703823edd191d1cdc8de5b9c645f2d4b53cb0 100644
--- a/chrome/browser/spellchecker/spellcheck_service.h
+++ b/chrome/browser/spellchecker/spellcheck_service.h
@@ -30,7 +30,7 @@ class RenderProcessHost;
 
 // Encapsulates the browser side spellcheck service. There is one of these per
 // profile and each is created by the SpellCheckServiceFactory.  The
-// SpellCheckService maintains any per-profile information about spellcheck.
+// SpellcheckService maintains any per-profile information about spellcheck.
 class SpellcheckService : public ProfileKeyedService,
                           public content::NotificationObserver,
                           public SpellcheckCustomDictionary::Observer {
@@ -70,10 +70,10 @@ class SpellcheckService : public ProfileKeyedService,
   // metrics. This should be called only if the metrics recording is active.
   void StartRecordingMetrics(bool spellcheck_enabled);
 
-  // Pass all renderers some basic initialization infomration.
+  // Pass all renderers some basic initialization information.
   void InitForAllRenderers();
 
-  // Pass the renderer some basic intialization information. Note that the
+  // Pass the renderer some basic initialization information. Note that the
   // renderer will not load Hunspell until it needs to.
   void InitForRenderer(content::RenderProcessHost* process);
 
@@ -91,8 +91,8 @@ class SpellcheckService : public ProfileKeyedService,
 
   // SpellcheckCustomDictionary::Observer implementation.
   virtual void OnCustomDictionaryLoaded() OVERRIDE;
-  virtual void OnCustomDictionaryWordAdded(const std::string& word) OVERRIDE;
-  virtual void OnCustomDictionaryWordRemoved(const std::string& word) OVERRIDE;
+  virtual void OnCustomDictionaryChanged(
+      const SpellcheckCustomDictionary::Change* dictionary_change) OVERRIDE;

[groby-ooo-7-16, 2013/01/15 01:19:20]

I'd prefer this to be a const ref. (For one, this should never be called with a
NULL ptr.)

[please use gerrit instead, 2013/01/16 02:06:05]

Done.

 
  private:
   FRIEND_TEST_ALL_PREFIXES(SpellcheckServiceBrowserTest, DeleteCorruptedBDICT);