Sync user's custom spellcheck dictionary

chrome/browser/spellchecker/spellcheck_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_
 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 12 matching lines @@
 namespace base {
 class WaitableEvent;
 }
 
 namespace content {
 class RenderProcessHost;
 }
 
 // Encapsulates the browser side spellcheck service. There is one of these per
 // profile and each is created by the SpellCheckServiceFactory.  The
-// SpellCheckService maintains any per-profile information about spellcheck.
+// SpellcheckService maintains any per-profile information about spellcheck.
 class SpellcheckService : public ProfileKeyedService,
                           public content::NotificationObserver,
                           public SpellcheckCustomDictionary::Observer {
  public:
   // Event types used for reporting the status of this class and its derived
   // classes to browser tests.
   enum EventType {
     BDICT_NOTINITIALIZED,
     BDICT_CORRUPTED,
   };
@@ skipping 19 matching lines @@
   // Signals the event attached by AttachTestEvent() to report the specified
   // event to browser tests. This function is called by this class and its
   // derived classes to report their status. This function does not do anything
   // when we do not set an event to |status_event_|.
   static bool SignalStatusEvent(EventType type);
 
   // Instantiates SpellCheckHostMetrics object and makes it ready for recording
   // metrics. This should be called only if the metrics recording is active.
   void StartRecordingMetrics(bool spellcheck_enabled);
 
-  // Pass all renderers some basic initialization infomration.
+  // Pass all renderers some basic initialization information.
   void InitForAllRenderers();
 
-  // Pass the renderer some basic intialization information. Note that the
+  // Pass the renderer some basic initialization information. Note that the
   // renderer will not load Hunspell until it needs to.
   void InitForRenderer(content::RenderProcessHost* process);
 
   // Returns a metrics counter associated with this object,
   // or null when metrics recording is disabled.
   SpellCheckHostMetrics* GetMetrics() const;
 
   // Returns the instance of the custom dictionary.
   SpellcheckCustomDictionary* GetCustomDictionary();
 
   // NotificationProfile implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // SpellcheckCustomDictionary::Observer implementation.
   virtual void OnCustomDictionaryLoaded() OVERRIDE;
-  virtual void OnCustomDictionaryWordAdded(const std::string& word) OVERRIDE;
-  virtual void OnCustomDictionaryWordRemoved(const std::string& word) OVERRIDE;
+  virtual void OnCustomDictionaryChanged(
+      const SpellcheckCustomDictionary::Change* dictionary_change) OVERRIDE;

[groby-ooo-7-16, 2013/01/15 01:19:20]

I'd prefer this to be a const ref. (For one, this should never be called with a
NULL ptr.)

[please use gerrit instead, 2013/01/16 02:06:05]

Done.

 
  private:
   FRIEND_TEST_ALL_PREFIXES(SpellcheckServiceBrowserTest, DeleteCorruptedBDICT);
 
   // Attaches an event so browser tests can listen the status events.
   static void AttachStatusEvent(base::WaitableEvent* status_event);
 
   // Waits until a spellchecker updates its status. This function returns
   // immediately when we do not set an event to |status_event_|.
   static EventType WaitStatusEvent();
@@ skipping 17 matching lines @@
   scoped_ptr<SpellcheckCustomDictionary> custom_dictionary_;
 
   scoped_ptr<SpellcheckHunspellDictionary> hunspell_dictionary_;
 
   base::WeakPtrFactory<SpellcheckService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SpellcheckService);
 };
 
 #endif  // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_