Reland Issue 1132473003: Cache IsNonBrowserProcess

chrome_elf/chrome_elf_main.cc

Index: chrome_elf/chrome_elf_main.cc
diff --git a/chrome_elf/chrome_elf_main.cc b/chrome_elf/chrome_elf_main.cc
index 989493a122e13470120176b3940036c836775672..52212cc91f45e961071083a1d290c948ea0fe535 100644
--- a/chrome_elf/chrome_elf_main.cc
+++ b/chrome_elf/chrome_elf_main.cc
@@ -8,6 +8,7 @@
 
 #include "chrome_elf/blacklist/blacklist.h"
 #include "chrome_elf/breakpad.h"
+#include "chrome_elf/chrome_elf_util.h"
 #include "chrome_elf/ntdll_cache.h"
 
 void SignalChromeElf() {
@@ -16,6 +17,7 @@ void SignalChromeElf() {
 
 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
   if (reason == DLL_PROCESS_ATTACH) {
+    InitializeProcessType();

[grt (UTC plus 2), 2015/05/14 14:16:10]

the problem was that this was happening too late?

[Cait (Slow), 2015/05/14 14:50:16]

InitializeCrashReporting() calls IsNonBrowserProcess() to figure out whether it
should report the crash as a renderer or browser crash
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome_elf/breakpa...),
so InitProcessType() needs to run before InitializeCrashReporting.

I'm actually surprised this was working on any bots the way it was before :\

     InitializeCrashReporting();
 
     __try {