Reland Issue 1132473003: Cache IsNonBrowserProcess

chrome_elf/chrome_elf_main.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 
 #include "chrome_elf/chrome_elf_main.h"
 
 #include "chrome_elf/blacklist/blacklist.h"
 #include "chrome_elf/breakpad.h"
+#include "chrome_elf/chrome_elf_util.h"
 #include "chrome_elf/ntdll_cache.h"
 
 void SignalChromeElf() {
   blacklist::ResetBeacon();
 }
 
 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
   if (reason == DLL_PROCESS_ATTACH) {
+    InitializeProcessType();

[grt (UTC plus 2), 2015/05/14 14:16:10]

the problem was that this was happening too late?

[Cait (Slow), 2015/05/14 14:50:16]

InitializeCrashReporting() calls IsNonBrowserProcess() to figure out whether it
should report the crash as a renderer or browser crash
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome_elf/breakpa...),
so InitProcessType() needs to run before InitializeCrashReporting.

I'm actually surprised this was working on any bots the way it was before :\

     InitializeCrashReporting();
 
     __try {
       InitCache();
       blacklist::Initialize(false);  // Don't force, abort if beacon is present.
     } __except(GenerateCrashDump(GetExceptionInformation())) {
     }
   }
 
   return TRUE;
 }