Reland Issue 1132473003: Cache IsNonBrowserProcess

Reland Issue 1132473003: Cache IsNonBrowserProcess

so we only take a loader-lock the first time.

BUG=485656, 477137
Committed: https://crrev.com/c393a5b46e49e17ed064cf6074ea43a06cffaf41
Cr-Commit-Position: refs/heads/master@{#329911}

[Cait (Slow), 2015-05-14 00:09:55]

caitkp@chromium.org changed reviewers:
+ grt@chromium.org

[Cait (Slow), 2015-05-14 00:09:55]

Greg, PTAL -- Thanks!

[grt (UTC plus 2), 2015-05-14 14:16:10]

https://codereview.chromium.org/1144433004/diff/20001/chrome_elf/chrome_elf_m...
File chrome_elf/chrome_elf_main.cc (right):

https://codereview.chromium.org/1144433004/diff/20001/chrome_elf/chrome_elf_m...
chrome_elf/chrome_elf_main.cc:20: InitializeProcessType();
the problem was that this was happening too late?

https://codereview.chromium.org/1144433004/diff/20001/chrome_elf/chrome_elf_u...
File chrome_elf/chrome_elf_util_unittest.cc (right):

https://codereview.chromium.org/1144433004/diff/20001/chrome_elf/chrome_elf_u...
chrome_elf/chrome_elf_util_unittest.cc:52: EXPECT_TRUE(g_process_type ==
ProcessType::UNINITIALIZED);
nit:
  EXPECT_EQ(ProcessType::UNINITIALIZED, g_process_type);

[Cait (Slow), 2015-05-14 14:50:16]

https://codereview.chromium.org/1144433004/diff/20001/chrome_elf/chrome_elf_m...
File chrome_elf/chrome_elf_main.cc (right):

https://codereview.chromium.org/1144433004/diff/20001/chrome_elf/chrome_elf_m...
chrome_elf/chrome_elf_main.cc:20: InitializeProcessType();
On 2015/05/14 14:16:10, grt wrote:
> the problem was that this was happening too late?

InitializeCrashReporting() calls IsNonBrowserProcess() to figure out whether it
should report the crash as a renderer or browser crash
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome_elf/breakpa...),
so InitProcessType() needs to run before InitializeCrashReporting.

I'm actually surprised this was working on any bots the way it was before :\

https://codereview.chromium.org/1144433004/diff/20001/chrome_elf/chrome_elf_u...
File chrome_elf/chrome_elf_util_unittest.cc (right):

https://codereview.chromium.org/1144433004/diff/20001/chrome_elf/chrome_elf_u...
chrome_elf/chrome_elf_util_unittest.cc:52: EXPECT_TRUE(g_process_type ==
ProcessType::UNINITIALIZED);
On 2015/05/14 14:16:10, grt wrote:
> nit:
>   EXPECT_EQ(ProcessType::UNINITIALIZED, g_process_type);

Done.

[grt (UTC plus 2), 2015-05-14 15:10:44]

lgtm

[Cait (Slow), 2015-05-14 18:42:36]

The CQ bit was checked by caitkp@chromium.org

[commit-bot: I haz the power, 2015-05-14 18:44:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144433004/40001

[commit-bot: I haz the power, 2015-05-14 19:56:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-14 19:57:21]

Patchset 3 (id:??) landed as
https://crrev.com/c393a5b46e49e17ed064cf6074ea43a06cffaf41
Cr-Commit-Position: refs/heads/master@{#329911}