Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1144303003: Use signature inheritance when method types are unchanged (Closed)

Created:
5 years, 7 months ago by Leaf
Modified:
5 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use signature inheritance when method types are unchanged BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/78b473534531c670c92207387f6ce5de533fbc74

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove empty signatures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -533 lines) Patch
M lib/runtime/dart/_foreign_helper.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M lib/runtime/dart/_interceptors.js View 1 9 chunks +2 lines, -30 lines 0 comments Download
M lib/runtime/dart/_internal.js View 1 14 chunks +2 lines, -20 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 2 chunks +2 lines, -8 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 1 32 chunks +6 lines, -88 lines 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 3 chunks +0 lines, -3 lines 0 comments Download
M lib/runtime/dart/async.js View 1 28 chunks +2 lines, -57 lines 0 comments Download
M lib/runtime/dart/collection.js View 1 35 chunks +16 lines, -87 lines 0 comments Download
M lib/runtime/dart/convert.js View 1 21 chunks +5 lines, -46 lines 0 comments Download
M lib/runtime/dart/core.js View 1 36 chunks +1 line, -91 lines 0 comments Download
M lib/runtime/dart/isolate.js View 1 8 chunks +0 lines, -16 lines 0 comments Download
M lib/runtime/dart/math.js View 1 5 chunks +0 lines, -7 lines 0 comments Download
M lib/runtime/dart/typed_data.js View 1 20 chunks +0 lines, -21 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 2 chunks +9 lines, -3 lines 0 comments Download
M test/browser/runtime_tests.js View 1 chunk +11 lines, -0 lines 0 comments Download
M test/codegen/expect/DeltaBlue.js View 1 3 chunks +2 lines, -14 lines 0 comments Download
M test/codegen/expect/cascade.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M test/codegen/expect/constructors.js View 1 5 chunks +0 lines, -16 lines 0 comments Download
M test/codegen/expect/fieldtest.js View 1 5 chunks +0 lines, -6 lines 0 comments Download
M test/codegen/expect/functions.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/methods.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/misc.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M test/codegen/expect/names.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/opassign.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/sunflower/dom.js View 1 2 chunks +0 lines, -6 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M test/codegen/expect/temps.js View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Leaf
5 years, 7 months ago (2015-05-20 20:06:53 UTC) #2
Jennifer Messerly
lgtm++ https://codereview.chromium.org/1144303003/diff/1/lib/runtime/dart/async.js File lib/runtime/dart/async.js (right): https://codereview.chromium.org/1144303003/diff/1/lib/runtime/dart/async.js#newcode1231 lib/runtime/dart/async.js:1231: dart.setSignature(_ControllerSubscription, {}); we could skip empty signatures too?
5 years, 7 months ago (2015-05-20 20:16:22 UTC) #3
Leaf
https://codereview.chromium.org/1144303003/diff/1/lib/runtime/dart/async.js File lib/runtime/dart/async.js (right): https://codereview.chromium.org/1144303003/diff/1/lib/runtime/dart/async.js#newcode1231 lib/runtime/dart/async.js:1231: dart.setSignature(_ControllerSubscription, {}); On 2015/05/20 20:16:22, John Messerly wrote: > ...
5 years, 7 months ago (2015-05-20 20:41:36 UTC) #4
Leaf
5 years, 7 months ago (2015-05-20 20:41:52 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
78b473534531c670c92207387f6ce5de533fbc74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698