Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: lib/runtime/dart/_interceptors.js

Issue 1144303003: Use signature inheritance when method types are unchanged (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Remove empty signatures Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_foreign_helper.js ('k') | lib/runtime/dart/_internal.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_interceptors.js
diff --git a/lib/runtime/dart/_interceptors.js b/lib/runtime/dart/_interceptors.js
index 2d3a82c0125acc8b88b3ca1fb22e687c8af5d725..5eea67bf908012022bbcac9a709fee236c0f65e8 100644
--- a/lib/runtime/dart/_interceptors.js
+++ b/lib/runtime/dart/_interceptors.js
@@ -14,19 +14,16 @@ var _js_embedded_names = dart.import(_js_embedded_names);
}
}
JSMutableArray[dart.implements] = () => [JSMutableIndexable];
- dart.setSignature(JSMutableArray, {});
return JSMutableArray;
});
let JSMutableArray = JSMutableArray$();
let JSFixedArray$ = dart.generic(function(E) {
class JSFixedArray extends JSMutableArray$(E) {}
- dart.setSignature(JSFixedArray, {});
return JSFixedArray;
});
let JSFixedArray = JSFixedArray$();
let JSExtendableArray$ = dart.generic(function(E) {
class JSExtendableArray extends JSMutableArray$(E) {}
- dart.setSignature(JSExtendableArray, {});
return JSExtendableArray;
});
let JSExtendableArray = JSExtendableArray$();
@@ -50,11 +47,7 @@ var _js_embedded_names = dart.import(_js_embedded_names);
}
}
dart.setSignature(Interceptor, {
- methods: () => ({
- '==': dart.functionType(core.bool, [core.Object]),
- toString: dart.functionType(core.String, []),
- noSuchMethod: dart.functionType(dart.dynamic, [core.Invocation])
- })
+ methods: () => ({'==': dart.functionType(core.bool, [core.Object])})
});
let _isInt32 = Symbol('_isInt32');
let _tdivFast = Symbol('_tdivFast');
@@ -389,7 +382,6 @@ var _js_embedded_names = dart.import(_js_embedded_names);
toStringAsExponential: dart.functionType(core.String, [], [core.int]),
toStringAsPrecision: dart.functionType(core.String, [core.int]),
toRadixString: dart.functionType(core.String, [core.int]),
- toString: dart.functionType(core.String, []),
'unary-': dart.functionType(core.num, []),
'+': dart.functionType(core.num, [core.num]),
'-': dart.functionType(core.num, [core.num]),
@@ -501,17 +493,13 @@ var _js_embedded_names = dart.import(_js_embedded_names);
}
}
JSDouble[dart.implements] = () => [core.double];
- dart.setSignature(JSDouble, {});
class JSPositiveInt extends JSInt {
JSPositiveInt() {
super.JSInt();
}
}
- dart.setSignature(JSPositiveInt, {});
class JSUInt32 extends JSPositiveInt {}
- dart.setSignature(JSUInt32, {});
class JSUInt31 extends JSUInt32 {}
- dart.setSignature(JSUInt31, {});
let _defaultSplit = Symbol('_defaultSplit');
class JSString extends Interceptor {
JSString() {
@@ -958,7 +946,6 @@ var _js_embedded_names = dart.import(_js_embedded_names);
lastIndexOf: dart.functionType(core.int, [core.Pattern], [core.int]),
contains: dart.functionType(core.bool, [core.Pattern], [core.int]),
compareTo: dart.functionType(core.int, [core.String]),
- toString: dart.functionType(core.String, []),
get: dart.functionType(core.String, [core.int])
}),
statics: () => ({
@@ -1122,9 +1109,6 @@ var _js_embedded_names = dart.import(_js_embedded_names);
}
}
JSBool[dart.implements] = () => [core.bool];
- dart.setSignature(JSBool, {
- methods: () => ({toString: dart.functionType(core.String, [])})
- });
class JSNull extends Interceptor {
JSNull() {
super.Interceptor();
@@ -1147,18 +1131,11 @@ var _js_embedded_names = dart.import(_js_embedded_names);
}
JSNull[dart.implements] = () => [core.Null];
dart.setSignature(JSNull, {
- methods: () => ({
- '==': dart.functionType(core.bool, [dart.dynamic]),
- toString: dart.functionType(core.String, []),
- noSuchMethod: dart.functionType(dart.dynamic, [core.Invocation])
- })
+ methods: () => ({'==': dart.functionType(core.bool, [dart.dynamic])})
});
class JSIndexable extends core.Object {}
- dart.setSignature(JSIndexable, {});
class JSMutableIndexable extends JSIndexable {}
- dart.setSignature(JSMutableIndexable, {});
class JSObject extends core.Object {}
- dart.setSignature(JSObject, {});
class JavaScriptObject extends Interceptor {
JavaScriptObject() {
super.Interceptor();
@@ -1171,13 +1148,11 @@ var _js_embedded_names = dart.import(_js_embedded_names);
}
}
JavaScriptObject[dart.implements] = () => [JSObject];
- dart.setSignature(JavaScriptObject, {});
class PlainJavaScriptObject extends JavaScriptObject {
PlainJavaScriptObject() {
super.JavaScriptObject();
}
}
- dart.setSignature(PlainJavaScriptObject, {});
class UnknownJavaScriptObject extends JavaScriptObject {
UnknownJavaScriptObject() {
super.JavaScriptObject();
@@ -1186,9 +1161,6 @@ var _js_embedded_names = dart.import(_js_embedded_names);
return String(this);
}
}
- dart.setSignature(UnknownJavaScriptObject, {
- methods: () => ({toString: dart.functionType(core.String, [])})
- });
// Exports:
exports.JSArray = JSArray;
exports.JSMutableArray$ = JSMutableArray$;
« no previous file with comments | « lib/runtime/dart/_foreign_helper.js ('k') | lib/runtime/dart/_internal.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698