Fix array-out-of-bounds error in hunspell

src/hunspell/suggestmgr.cxx

Index: src/hunspell/suggestmgr.cxx
diff --git a/src/hunspell/suggestmgr.cxx b/src/hunspell/suggestmgr.cxx
index 76ab2032658751fd8388670e3e0a09696fdeb175..2d69290661b17335ff6db46bbc7482be2e0a83c6 100644
--- a/src/hunspell/suggestmgr.cxx
+++ b/src/hunspell/suggestmgr.cxx
@@ -845,8 +845,8 @@ int SuggestMgr::forgotchar(char ** wlst, const char * word, int ns, int cpdsugge
 // error is missing a letter it needs
 int SuggestMgr::forgotchar_utf(char ** wlst, const w_char * word, int wl, int ns, int cpdsuggest)
 {
-   w_char  candidate_utf[MAXSWL];
-   char    candidate[MAXSWUTF8L];
+   w_char  candidate_utf[MAXSWL + 1];
+   char    candidate[MAXSWUTF8L + 4];

[groby-ooo-7-16, 2012/12/12 01:19:38]

does this work for 100 character pastes now? And 101? ;)

(I.e. where do we clip wl to be < MAXSWL)?

[please use gerrit instead, 2012/12/12 05:33:53]

Words of 100 characters or more do not get passed into this method from
experience. As for the exact location of clipping wl to be < MAXSWL, I will step
through the code tomorrow, because browsing the code was not fruitful. 

[please use gerrit instead, 2012/12/12 21:00:01]

The clip of wl to be < MAXSWL happens on line 140 in hunspell.cxx:

if (*nc >= MAXWORDLEN) return 0;

(MAXWORDLEN is defined to be 100 in atypes.hxx.)

This sets wl=0 in Hunspell::suggest(), which prevents calling
SuggestMgr::suggest().

    w_char * p;
    clock_t timelimit = clock();
    int timer = MINTIMER;