Fix array-out-of-bounds error in hunspell

src/hunspell/suggestmgr.cxx

 #include "license.hunspell"
 #include "license.myspell"
 
 #include <stdlib.h> 
 #include <string.h>
 #include <stdio.h> 
 #include <ctype.h>
 
 #include "suggestmgr.hxx"
 #include "htypes.hxx"
@@ skipping 827 matching lines @@
          if (ns == -1) return -1;
          if (!timer) return ns;
       }
    }
    return ns;
 }
 
 // error is missing a letter it needs
 int SuggestMgr::forgotchar_utf(char ** wlst, const w_char * word, int wl, int ns, int cpdsuggest)
 {
-   w_char  candidate_utf[MAXSWL];
-   char    candidate[MAXSWUTF8L];
+   w_char  candidate_utf[MAXSWL + 1];
+   char    candidate[MAXSWUTF8L + 4];

[groby-ooo-7-16, 2012/12/12 01:19:38]

does this work for 100 character pastes now? And 101? ;)

(I.e. where do we clip wl to be < MAXSWL)?

[please use gerrit instead, 2012/12/12 05:33:53]

Words of 100 characters or more do not get passed into this method from
experience. As for the exact location of clipping wl to be < MAXSWL, I will step
through the code tomorrow, because browsing the code was not fruitful. 

[please use gerrit instead, 2012/12/12 21:00:01]

The clip of wl to be < MAXSWL happens on line 140 in hunspell.cxx:

if (*nc >= MAXWORDLEN) return 0;

(MAXWORDLEN is defined to be 100 in atypes.hxx.)

This sets wl=0 in Hunspell::suggest(), which prevents calling
SuggestMgr::suggest().

    w_char * p;
    clock_t timelimit = clock();
    int timer = MINTIMER;
    // try inserting a tryme character at the end of the word and before every letter
    for (int i = 0;  i < ctryl;  i++) {
       memcpy (candidate_utf, word, wl * sizeof(w_char));
       for (p = candidate_utf + wl;  p >= candidate_utf; p--)  {
          *(p + 1) = *p;
          *p = ctry_utf[i];
          u16_u8(candidate, MAXSWUTF8L, candidate_utf, wl + 1);
@@ skipping 1287 matching lines @@
       len++;
       i--;
       j--;
     } else if (result[i*(n+1) + j] == LCS_UP) {
       i--;
     } else j--;
   }
   free(result);
   return len;
 }