Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1144163004: dart2js cps: Always use interceptors and type tags for 'is' checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Long line Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 45d75902e0c0b1a9e35f5e6fc740f5faacbaf32d..b709f29f6ed62293c4f14c813b6fd9e7e61f366f 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -15,8 +15,6 @@ import '../../constants/values.dart';
import '../../dart2jslib.dart';
import '../../dart_types.dart';
-part 'type_test_emitter.dart';
-
class CodegenBailout {
final tree_ir.Node node;
final String reason;
@@ -27,8 +25,7 @@ class CodegenBailout {
}
class CodeGenerator extends tree_ir.StatementVisitor
- with tree_ir.ExpressionVisitor<js.Expression>,
- TypeTestEmitter {
+ with tree_ir.ExpressionVisitor<js.Expression> {
final CodegenRegistry registry;
final Glue glue;
@@ -361,7 +358,7 @@ class CodeGenerator extends tree_ir.StatementVisitor
if (type is InterfaceType && type.isRaw) {
glue.registerIsCheck(type, registry);
js.Expression value = visitExpression(node.receiver);
- return emitSubtypeTest(node, value, type);
+ return js.js('!!#.#', [value, glue.getTypeTestTag(type)]);
}
return giveup(node, 'type check unimplemented for $type.');
}

Powered by Google App Engine
This is Rietveld 408576698