pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart - Issue 1144163004: dart2js cps: Always use interceptors and type tags for 'is' checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

Issue 1144163004: dart2js cps: Always use interceptors and type tags for 'is' checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Long line Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

index 3227cf1d01231e123d6e000a6ae1b7dab089e449..f9f33c58f5775a45e5050b7ca0f8bf6583cd1b79 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

@@ -401,7 +401,7 @@ class InvokeConstructor extends Expression implements Invoke {

// But then we need to special-case for is-checks with an erroneous .type as

// these will throw.

class TypeOperator extends Expression {

- final Reference<Primitive> receiver;

+ Reference<Primitive> receiver;

final DartType type;

final Reference<Continuation> continuation;

// TODO(johnniwinther): Use `Operator` class to encapsule the operator type.