Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1144133003: Add constants for FrameState input parameters (Closed)

Created:
5 years, 7 months ago by danno
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add constants for FrameState input parameters R=jarin@chromium.org Committed: https://crrev.com/c1253668bc0c36405a32c82775045ed11ca00a40 Cr-Commit-Position: refs/heads/master@{#28519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -23 lines) Patch
M src/compiler/frame-states.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +21 lines, -15 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danno
5 years, 7 months ago (2015-05-20 12:35:07 UTC) #1
Jarin
On 2015/05/20 12:35:07, danno wrote: It would be nice if the constants could live in ...
5 years, 7 months ago (2015-05-20 12:38:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144133003/1
5 years, 7 months ago (2015-05-20 13:12:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 13:42:15 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 13:42:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1253668bc0c36405a32c82775045ed11ca00a40
Cr-Commit-Position: refs/heads/master@{#28519}

Powered by Google App Engine
This is Rietveld 408576698