Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 1144133003: Add constants for FrameState input parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/instruction-selector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index 7d8d20043e43711289215b286115fd16f9f30d24..c1b879af25f46848c5408dff14736aedef454fe9 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -287,10 +287,13 @@ class JSBinopReduction final {
state_info.type(), state_info.bailout_id(),
OutputFrameStateCombine::PokeAt(1));
- return graph()->NewNode(op, frame_state->InputAt(0),
- frame_state->InputAt(1), frame_state->InputAt(2),
- frame_state->InputAt(3), frame_state->InputAt(4),
- frame_state->InputAt(5));
+ return graph()->NewNode(op,
+ frame_state->InputAt(kFrameStateParametersInput),
+ frame_state->InputAt(kFrameStateLocalsInput),
+ frame_state->InputAt(kFrameStateStackInput),
+ frame_state->InputAt(kFrameStateContextInput),
+ frame_state->InputAt(kFrameStateFunctionInput),
+ frame_state->InputAt(kFrameStateOuterStateInput));
}
Node* CreateFrameStateForRightInput(Node* frame_state, Node* converted_left) {
@@ -325,10 +328,12 @@ class JSBinopReduction final {
Node* new_stack =
graph()->NewNode(stack->op(), stack->InputCount(), &new_values.front());
- return graph()->NewNode(op, frame_state->InputAt(0),
- frame_state->InputAt(1), new_stack,
- frame_state->InputAt(3), frame_state->InputAt(4),
- frame_state->InputAt(5));
+ return graph()->NewNode(
+ op, frame_state->InputAt(kFrameStateParametersInput),
+ frame_state->InputAt(kFrameStateLocalsInput), new_stack,
+ frame_state->InputAt(kFrameStateContextInput),
+ frame_state->InputAt(kFrameStateFunctionInput),
+ frame_state->InputAt(kFrameStateOuterStateInput));
}
Node* ConvertPlainPrimitiveToNumber(Node* node) {
« no previous file with comments | « src/compiler/instruction-selector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698