[web_dev_style] Changing :pseudo-element to ::pseudo-element to match

[web_dev_style] Changing :pseudo-element to ::pseudo-element to match
future-facing CSS3 style. This also helps indicate which :pseudo types are
*elements* (actually has a DOM node) vs. *classes* (just used for applying a
selector).

BUG=None
TEST=chrome/browser/resources/test_presubmit.py
R=tbreisacher@chromium.org,estade@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171669

[Dan Beam, 2012-12-05 07:21:41]

https://codereview.chromium.org/11441008/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/bubble.css (right):

https://codereview.chromium.org/11441008/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/bubble.css:32: html[dir=ltf]
.bubble-top::before {
^ I'll contact the author about this

[Dan Beam, 2012-12-05 07:24:17]

https://codereview.chromium.org/11441008/diff/1/chrome/browser/resources/chro...
File chrome/browser/resources/chromeos/login/bubble.css (right):

https://codereview.chromium.org/11441008/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/login/bubble.css:32: html[dir=ltf]
.bubble-top::before {
On 2012/12/05 07:21:41, Dan Beam wrote:
> ^ I'll contact the author about this

Asked Ivan on original CL - https://codereview.chromium.org/9310050/

[Tyler Breisacher (Chromium), 2012-12-05 18:59:57]

https://codereview.chromium.org/11441008/diff/2001/chrome/browser/resources/w...
File chrome/browser/resources/web_dev_style/css_checker.py (right):

https://codereview.chromium.org/11441008/diff/2001/chrome/browser/resources/w...
chrome/browser/resources/web_dev_style/css_checker.py:103: pseudo_elements =
['after',
Presumably more things will be added to this list eventually. Can we link to an
official list in the CSS spec or something, so that it's easy to keep this up to
date?

https://codereview.chromium.org/11441008/diff/2001/chrome/browser/resources/w...
chrome/browser/resources/web_dev_style/css_checker.py:161: pseudo_reg =
r'(?<!:):([a-z-]+)(?=[^{}]+?{)'
Please consider using Python's verbose regular expressions:
http://docs.python.org/2/library/re.html#re.VERBOSE

I suspect that most people cannot remember the difference between (?<...) and
(?=...), etc. so you can save readers a lot of time with a bit of explanation.

[Dan Beam, 2012-12-05 20:36:29]

I'll add re.VERBOSE stuff soon

https://codereview.chromium.org/11441008/diff/2001/chrome/browser/resources/w...
File chrome/browser/resources/web_dev_style/css_checker.py (right):

https://codereview.chromium.org/11441008/diff/2001/chrome/browser/resources/w...
chrome/browser/resources/web_dev_style/css_checker.py:103: pseudo_elements =
['after',
On 2012/12/05 18:59:57, Tyler Breisacher wrote:
> Presumably more things will be added to this list eventually. Can we link to
an
> official list in the CSS spec or something, so that it's easy to keep this up
to
> date?

Very few are actually official (just before, after, first-letter, first-line),
the rest are all just in webkit or non-standard impls.

[Tyler Breisacher (Chromium), 2012-12-05 20:45:14]

lgtm

https://codereview.chromium.org/11441008/diff/2001/chrome/browser/resources/w...
File chrome/browser/resources/web_dev_style/css_checker.py (right):

https://codereview.chromium.org/11441008/diff/2001/chrome/browser/resources/w...
chrome/browser/resources/web_dev_style/css_checker.py:164: for p in
re.finditer(re.compile(pseudo_reg, re.MULTILINE), contents):
optional nit: Do the compilation when you first write the regex: pseudo_reg =
re.compile(r'(?<!:):([a-z-]+)(?=[^{}]+?{)', re.MULTILINE)

That way when someone is deciphering the regular expression, they already know
they're looking at a multi-line regex.

[Dan Beam, 2012-12-06 22:13:27]

filed regex cleanup as http://code.google.com/p/chromium/issues/detail?id=164702

[commit-bot: I haz the power, 2012-12-06 22:17:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11441008/12001

[commit-bot: I haz the power, 2012-12-07 01:19:20]

Change committed as 171669