Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7091)

Unified Diff: chrome/browser/resources/test_presubmit.py

Issue 11441008: [web_dev_style] Changing :pseudo-element to ::pseudo-element to match (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/test_presubmit.py
diff --git a/chrome/browser/resources/test_presubmit.py b/chrome/browser/resources/test_presubmit.py
index 3827ed22b3c0c9c8de1f0abc2fc46a4141ee3b24..58c311d3afa5ee98657f11c3288736f9bd35bb85 100755
--- a/chrome/browser/resources/test_presubmit.py
+++ b/chrome/browser/resources/test_presubmit.py
@@ -449,6 +449,25 @@ div,a {
div, span,
div,a {""")
+ def testCssPseudoElementDoubleColon(self):
+ self.VerifyContentsProducesOutput("""
+a:href,
+br::after,
+::-webkit-scrollbar-thumb,
+a:not([empty]):hover:focus:active, /* shouldn't catch here and above */
+abbr:after,
+.tree-label:empty:after,
+b:before,
+:-webkit-scrollbar {
+ rule: value;
+}""", """
+- Pseudo-elements should use double colon (i.e. ::after).
+ :after (should be ::after)
+ :after (should be ::after)
+ :before (should be ::before)
+ :-webkit-scrollbar (should be ::-webkit-scrollbar)
+ """)
+
def testCssRgbIfNotGray(self):
self.VerifyContentsProducesOutput("""
#abc,
« no previous file with comments | « chrome/browser/resources/task_manager/task_manager.css ('k') | chrome/browser/resources/web_dev_style/css_checker.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698