Issue 1143993004: Revert "Revert "Make shell child processes slaves.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1143993004: Revert "Revert "Make shell child processes slaves."" (Closed)

Created:
5 years, 7 months ago by viettrungluu

Modified:
5 years, 7 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert "Revert "Make shell child processes slaves."" This reverts commit 8a354f1948e5f28305e383813ee111cf201f6a2b. I unreverted the revert of the stuff that it depended on. TBR=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b712a8d160790959cb484d9df206dfe413a93904

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -27 lines)			Patch
M	shell/child_main.cc	View	6 chunks	+27 lines, -14 lines	0 comments	Download
M	shell/child_process_host.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	shell/child_process_host.cc	View	4 chunks	+13 lines, -5 lines	0 comments	Download
M	shell/child_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	shell/child_switches.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	shell/context.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	shell/shell_test_main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

viettrungluu

5 years, 7 months ago (2015-05-20 19:27:21 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b712a8d160790959cb484d9df206dfe413a93904 (presubmit successful).