shell/context.cc - Issue 1143993004: Revert "Revert "Make shell child processes slaves.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: shell/context.cc

Issue 1143993004: Revert "Revert "Make shell child processes slaves."" (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: shell/context.cc

diff --git a/shell/context.cc b/shell/context.cc

index 2e1b71b21509aaf021fd970c7c52c050a8d708ed..40abac585d478ba946c7a3814c78ffd2cdd4c944 100644

--- a/shell/context.cc

+++ b/shell/context.cc

@@ -347,9 +347,7 @@ void Context::OnShutdownComplete() {

}

void Context::OnSlaveDisconnect(mojo::embedder::SlaveInfo slave_info) {

- // TODO(vtl): We don't make any proper slave processes yet, so this shouldn't

- // be called yet.

- NOTREACHED();

+ // TODO(vtl): Do something, once we actually have |slave_info|.

}

void Context::Run(const GURL& url) {

« no previous file with comments | « shell/child_switches.cc ('k') | shell/shell_test_main.cc » ('j') | no next file with comments »