Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1143833002: Revert of Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight} (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight} (patchset #2 id:20001 of https://codereview.chromium.org/1139663005/) Reason for revert: [Sheriff] Breaks win nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6872 Original issue's description: > Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight} > > This patch adds implementations for additional TypedArray methods > from the ES6 spec, together with tests adapted from array code. > > R=arv@chromium.org > BUG=v8:3578 > LOG=Y > > Committed: https://crrev.com/59ef8c5f3282f01b5990b3a46a2a3a829b699a13 > Cr-Commit-Position: refs/heads/master@{#28488} TBR=arv@chromium.org,dehrenberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3578 Committed: https://crrev.com/6f58ffa140b3aae3215683a258b995efd79bfbd0 Cr-Commit-Position: refs/heads/master@{#28489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -614 lines) Patch
M src/array.js View 11 chunks +43 lines, -76 lines 0 comments Download
M src/harmony-typedarray.js View 5 chunks +3 lines, -86 lines 0 comments Download
D test/mjsunit/harmony/typedarray-iteration.js View 1 chunk +0 lines, -196 lines 0 comments Download
D test/mjsunit/harmony/typedarray-reduce.js View 1 chunk +0 lines, -256 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight}
5 years, 7 months ago (2015-05-19 16:54:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143833002/1
5 years, 7 months ago (2015-05-19 16:55:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 16:56:09 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 16:56:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f58ffa140b3aae3215683a258b995efd79bfbd0
Cr-Commit-Position: refs/heads/master@{#28489}

Powered by Google App Engine
This is Rietveld 408576698