Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight}

Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight}

This patch adds implementations for additional TypedArray methods
from the ES6 spec, together with tests adapted from array code.

R=arv@chromium.org
BUG=v8:3578
LOG=Y

Committed: https://crrev.com/59ef8c5f3282f01b5990b3a46a2a3a829b699a13
Cr-Commit-Position: refs/heads/master@{#28488}

[arv (Not doing code reviews), 2015-05-18 22:54:24]

https://codereview.chromium.org/1139663005/diff/1/src/array.js
File src/array.js (right):

https://codereview.chromium.org/1139663005/diff/1/src/array.js#newcode1254
src/array.js:1254: $innerArraySome = InnerArraySome;
Can you put all of these at the end?

https://codereview.chromium.org/1139663005/diff/1/src/array.js#newcode1645
src/array.js:1645: 
should go here

https://codereview.chromium.org/1139663005/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):

https://codereview.chromium.org/1139663005/diff/1/src/harmony-typedarray.js#n...
src/harmony-typedarray.js:132: return ConstructTypedArrayLike(this, array);
This one can be preallocated instead of using a temporary array. Add a TODO?

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
File test/mjsunit/harmony/typedarray-iteration.js (right):

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-iteration.js:42: a = new
constructor([1,42,3,42,4]);
space after comma

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-iteration.js:70: }, "");
stick to either " or '

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-iteration.js:88: // %TypedArray%.prototype.map
Other tests tend to use the following format:

(function TestNameOfTest() {
  ...
})();

Then the stack trace will tell you which part you was failing.

Then you can also remove the comment since the name should explain what is being
tested.

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-iteration.js:132: 
map is a bit special since the return value might no longer fit (or be a number)
in the typed array. Can you add a few tests for that?

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
File test/mjsunit/harmony/typedarray-reduce.js (right):

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-reduce.js:8: * @fileoverview Test
%TypedArray%.prototype.reduce and .reduceRight
no jsdoc needed

[dehrenberg, 2015-05-19 00:13:46]

https://codereview.chromium.org/1139663005/diff/1/src/array.js
File src/array.js (right):

https://codereview.chromium.org/1139663005/diff/1/src/array.js#newcode1254
src/array.js:1254: $innerArraySome = InnerArraySome;
On 2015/05/18 22:54:23, arv wrote:
> Can you put all of these at the end?

Done.

https://codereview.chromium.org/1139663005/diff/1/src/array.js#newcode1645
src/array.js:1645: 
On 2015/05/18 22:54:23, arv wrote:
> should go here

Done.

https://codereview.chromium.org/1139663005/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):

https://codereview.chromium.org/1139663005/diff/1/src/harmony-typedarray.js#n...
src/harmony-typedarray.js:132: return ConstructTypedArrayLike(this, array);
On 2015/05/18 22:54:23, arv wrote:
> This one can be preallocated instead of using a temporary array. Add a TODO?

Done.

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
File test/mjsunit/harmony/typedarray-iteration.js (right):

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-iteration.js:42: a = new
constructor([1,42,3,42,4]);
On 2015/05/18 22:54:23, arv wrote:
> space after comma

Done.

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-iteration.js:70: }, "");
On 2015/05/18 22:54:23, arv wrote:
> stick to either " or '

Done.

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-iteration.js:88: // %TypedArray%.prototype.map
On 2015/05/18 22:54:24, arv wrote:
> Other tests tend to use the following format:
> 
> (function TestNameOfTest() {
>   ...
> })();
> 
> Then the stack trace will tell you which part you was failing.
> 
> Then you can also remove the comment since the name should explain what is
being
> tested.
> 

Done.

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-iteration.js:132: 
On 2015/05/18 22:54:24, arv wrote:
> map is a bit special since the return value might no longer fit (or be a
number)
> in the typed array. Can you add a few tests for that?

Done.

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
File test/mjsunit/harmony/typedarray-reduce.js (right):

https://codereview.chromium.org/1139663005/diff/1/test/mjsunit/harmony/typeda...
test/mjsunit/harmony/typedarray-reduce.js:8: * @fileoverview Test
%TypedArray%.prototype.reduce and .reduceRight
On 2015/05/18 22:54:24, arv wrote:
> no jsdoc needed

Done.

[arv (Not doing code reviews), 2015-05-19 13:44:06]

LGTM

Please add a bug/todo for using InternalArray.

https://codereview.chromium.org/1139663005/diff/20001/src/array.js
File src/array.js (right):

https://codereview.chromium.org/1139663005/diff/20001/src/array.js#newcode1158
src/array.js:1158: function InnerArrayFilter(f, receiver, array, length) {
I think we have an issue with typed arrays since we are creating a new Array
which can have setters.

Object.defineProperty(Array.prototype, 1, {set: function(v) {
  alert(v);
});

For the typed arrays we can use InternalArray (where the spec asks for a List).

[dehrenberg, 2015-05-19 16:06:17]

On 2015/05/19 13:44:06, arv wrote:
> LGTM
> 
> Please add a bug/todo for using InternalArray.
> 
> https://codereview.chromium.org/1139663005/diff/20001/src/array.js
> File src/array.js (right):
> 
> https://codereview.chromium.org/1139663005/diff/20001/src/array.js#newcode1158
> src/array.js:1158: function InnerArrayFilter(f, receiver, array, length) {
> I think we have an issue with typed arrays since we are creating a new Array
> which can have setters.
> 
> Object.defineProperty(Array.prototype, 1, {set: function(v) {
>   alert(v);
> });
> 
> For the typed arrays we can use InternalArray (where the spec asks for a
List).

Filed v8:4128

[dehrenberg, 2015-05-19 16:06:23]

The CQ bit was checked by dehrenberg@chromium.org

[commit-bot: I haz the power, 2015-05-19 16:06:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139663005/20001

[commit-bot: I haz the power, 2015-05-19 16:32:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-19 16:33:24]

Patchset 2 (id:??) landed as
https://crrev.com/59ef8c5f3282f01b5990b3a46a2a3a829b699a13
Cr-Commit-Position: refs/heads/master@{#28488}

[Michael Achenbach, 2015-05-19 16:54:54]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1143833002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks win nosnap:
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20....