Issue 1143813002: Reland "[strong] Object literals create strong objects"

Issue 1143813002: Reland "[strong] Object literals create strong objects" (Closed)

Created:
5 years, 7 months ago by rossberg

Modified:
5 years, 7 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev, Paweł Hajdan Jr., conradw

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Reland "[strong] Object literals create strong objects" (patchset #4 id:60001 of https://codereview.chromium.org/1134333005/)" This reverts commit 81c080ef8e7c1a38622b870b351bb1e11b6c8a62. Patchset #1 is the original CL. Patchset #2 fixes a handlification bug that caused the crash. R=dslomov@chromium.org BUG=v8:3956 LOG=N Committed: https://crrev.com/2fa664fbe2a046426342449ba4447ef40d4279af Cr-Commit-Position: refs/heads/master@{#28497}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -55 lines)			Patch
M	include/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ast.h	View		9 chunks	+33 lines, -12 lines	0 comments	Download
M	src/bootstrapper.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/contexts.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/factory.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1	3 chunks	+18 lines, -8 lines	0 comments	Download
M	src/parser.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/preparser.h	View		5 chunks	+8 lines, -2 lines	0 comments	Download
M	src/runtime/runtime.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime/runtime-literals.cc	View		12 chunks	+27 lines, -16 lines	0 comments	Download
A	test/mjsunit/strong/literals.js	View		1 chunk	+79 lines, -0 lines	0 comments	Download
D	test/mjsunit/strong/objects.js	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143813002/20001

5 years, 7 months ago (2015-05-20 06:36:21 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 07:08:26 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/2fa664fbe2a046426342449ba4447ef40d4279af
Cr-Commit-Position: refs/heads/master@{#28497}