src/hydrogen.cc - Issue 1143813002: Reland "[strong] Object literals create strong objects"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 1143813002: Reland "[strong] Object literals create strong objects" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix handlification bug Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 4f04580376789ec692104af8d6f914bc62b53634..86bf7634296dcbf71b8a2debf27262464a1a1e3c 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -5790,7 +5790,8 @@ void HOptimizedGraphBuilder::VisitArrayLiteral(ArrayLiteral* expr) {

ASSIGN_RETURN_ON_EXCEPTION_VALUE(

isolate(), raw_boilerplate,

Runtime::CreateArrayLiteralBoilerplate(

- isolate(), literals, expr->constant_elements()),

+ isolate(), literals, expr->constant_elements(),

+ is_strong(function_language_mode())),

Bailout(kArrayBoilerplateCreationFailed));

boilerplate_object = Handle<JSObject>::cast(raw_boilerplate);

« no previous file with comments | « src/factory.cc ('k') | src/objects.cc » ('j') | no next file with comments »