Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: runtime/bin/io_buffer.cc

Issue 11438045: Make all allocation of external arrays used for IO use the IOBuffer class (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/io_buffer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/io_buffer.cc
diff --git a/runtime/bin/io_buffer.cc b/runtime/bin/io_buffer.cc
index 8ff95a05e27e146744cc6f6a9ce5d9b1f049691c..a07559d853483a83553868fc07882bebc58f54cc 100644
--- a/runtime/bin/io_buffer.cc
+++ b/runtime/bin/io_buffer.cc
@@ -4,19 +4,11 @@
#include "bin/io_buffer.h"
-static void BufferFree(void* buffer) {
- delete[] reinterpret_cast<uint8_t*>(buffer);
-}
-
-
Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) {
- uint8_t* data = new uint8_t[size];
- Dart_Handle result = Dart_NewExternalByteArray(data,
- size,
- data,
- BufferFree);
+ uint8_t* data = Allocate(size);
+ Dart_Handle result = Dart_NewExternalByteArray(data, size, data, Free);
if (Dart_IsError(result)) {
- BufferFree(data);
+ Free(data);
Dart_PropagateError(result);
}
if (buffer != NULL) {
@@ -24,3 +16,7 @@ Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) {
}
return result;
}
+
+uint8_t* IOBuffer::Allocate(intptr_t size) {
+ return new uint8_t[size];
+}
« no previous file with comments | « runtime/bin/io_buffer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698