Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: runtime/bin/io_buffer.cc

Issue 11438045: Make all allocation of external arrays used for IO use the IOBuffer class (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/io_buffer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/io_buffer.h" 5 #include "bin/io_buffer.h"
6 6
7 static void BufferFree(void* buffer) {
8 delete[] reinterpret_cast<uint8_t*>(buffer);
9 }
10
11
12 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) { 7 Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t **buffer) {
13 uint8_t* data = new uint8_t[size]; 8 uint8_t* data = Allocate(size);
14 Dart_Handle result = Dart_NewExternalByteArray(data, 9 Dart_Handle result = Dart_NewExternalByteArray(data, size, data, Free);
15 size,
16 data,
17 BufferFree);
18 if (Dart_IsError(result)) { 10 if (Dart_IsError(result)) {
19 BufferFree(data); 11 Free(data);
20 Dart_PropagateError(result); 12 Dart_PropagateError(result);
21 } 13 }
22 if (buffer != NULL) { 14 if (buffer != NULL) {
23 *buffer = data; 15 *buffer = data;
24 } 16 }
25 return result; 17 return result;
26 } 18 }
19
20 uint8_t* IOBuffer::Allocate(intptr_t size) {
21 return new uint8_t[size];
22 }
OLDNEW
« no previous file with comments | « runtime/bin/io_buffer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698