sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 11438044: Remove some warnings and errors from dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 11438044: Remove some warnings and errors from dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

index 036d1ac4b4de5a5b01413c5e9f163ad103e1e833..4e1359d4e7e69929db976b4a852bcfd39d1c7732 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

@@ -207,7 +207,7 @@ class SsaConstantFolder extends HBaseVisitor implements OptimizationPhase {

}

HInstruction handleInterceptorCall(HInvokeDynamic node) {

- if (node is !HInvokeDynamicMethod) return;

+ if (node is !HInvokeDynamicMethod) return null;

karlklose 2012/12/06 11:39:23 @ngeoffray: Is this the intention?

ngeoffray 2012/12/06 23:05:05 Yes, thanks Karl.

HInstruction input = node.inputs[1];

if (input.isString(types)

&& node.selector.name == const SourceString('toString')) {