Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: sdk/lib/_internal/compiler/implementation/native_handler.dart

Issue 11438044: Remove some warnings and errors from dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/native_handler.dart
diff --git a/sdk/lib/_internal/compiler/implementation/native_handler.dart b/sdk/lib/_internal/compiler/implementation/native_handler.dart
index 825069e70f3d51f76239e9295df207e321ad28eb..2bd4212446644b74015c99c2dd8e2a7e4dec91d9 100644
--- a/sdk/lib/_internal/compiler/implementation/native_handler.dart
+++ b/sdk/lib/_internal/compiler/implementation/native_handler.dart
@@ -801,7 +801,7 @@ void handleSsaNative(SsaBuilder builder, Expression nativeBody) {
// not a JS property on the DOM types, returns the type name.
if (element.name == const SourceString('typeName')
&& element.isGetter()
- && nativeEmitter.toNativeName(element.getEnclosingClass()) == 'DOMType') {
karlklose 2012/12/06 11:39:23 @sra: Is this dead code? The method name was chang
sra1 2012/12/10 22:46:11 Yup, it looks dead. lgtm to remove lines 797-809
+ && nativeEmitter.toNativeTag(element.getEnclosingClass()) == 'DOMType') {
Element helper =
compiler.findHelper(const SourceString('getTypeNameOf'));
builder.pushInvokeHelper1(helper, builder.localsHandler.readThis());

Powered by Google App Engine
This is Rietveld 408576698