Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: mojo/application/public/cpp/application_impl.h

Issue 1143793003: Remove application-specific args from Mandoline's shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/application/public/cpp/application_impl.h
diff --git a/mojo/application/public/cpp/application_impl.h b/mojo/application/public/cpp/application_impl.h
index a5d58f50f52dc5c18648cc207d5581cce6bd4f84..cecc934ff96ee44ad659ff6fc63b4010e84d9e4f 100644
--- a/mojo/application/public/cpp/application_impl.h
+++ b/mojo/application/public/cpp/application_impl.h
@@ -64,10 +64,6 @@ class ApplicationImpl : public Application {
const std::string& url() const { return url_; }
- // Returns any initial configuration arguments, passed by the Shell.
- const std::vector<std::string>& args() const { return args_; }
- bool HasArg(const std::string& arg) const;
-
// Requests a new connection to an application. Returns a pointer to the
// connection if the connection is permitted by this application's delegate,
// or nullptr otherwise. Caller does not take ownership. The pointer remains
@@ -84,9 +80,7 @@ class ApplicationImpl : public Application {
}
// Application implementation.
- void Initialize(ShellPtr shell,
- Array<String> args,
- const mojo::String& url) override;
+ void Initialize(ShellPtr shell, const mojo::String& url) override;
// Block until the Application is initialized, if it is not already.
void WaitForInitialize();
@@ -130,7 +124,6 @@ class ApplicationImpl : public Application {
ShellPtr shell_;
ShellPtrWatcher* shell_watch_;
std::string url_;
- std::vector<std::string> args_;
MOJO_DISALLOW_COPY_AND_ASSIGN(ApplicationImpl);
};
« no previous file with comments | « mojo/application/application_test_base_chromium.cc ('k') | mojo/application/public/cpp/lib/application_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698