Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: mojo/application/application_test_base_chromium.cc

Issue 1143793003: Remove application-specific args from Mandoline's shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/html_viewer.cc ('k') | mojo/application/public/cpp/application_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application/application_test_base_chromium.cc
diff --git a/mojo/application/application_test_base_chromium.cc b/mojo/application/application_test_base_chromium.cc
index bb9afa14247b80a7062ec893c95aa5432b8bb1c4..cf4920c0f69cff2ee4232e127c56ed84644e1129 100644
--- a/mojo/application/application_test_base_chromium.cc
+++ b/mojo/application/application_test_base_chromium.cc
@@ -40,9 +40,7 @@ class ShellGrabber : public Application {
private:
// Application implementation.
- void Initialize(ShellPtr shell,
- Array<String> args,
- const mojo::String& url) override {
+ void Initialize(ShellPtr shell, const mojo::String& url) override {
g_url = url;
g_application_request = binding_.Unbind();
g_shell = shell.Pass();
@@ -127,9 +125,8 @@ void ApplicationTestBase::SetUp() {
application_impl_ = new ApplicationImpl(GetApplicationDelegate(),
g_application_request.Pass());
- // Fake application initialization with the given command line arguments.
- Array<String> empty_args;
- application_impl_->Initialize(g_shell.Pass(), empty_args.Clone(), g_url);
+ // Fake application initialization.
+ application_impl_->Initialize(g_shell.Pass(), g_url);
}
void ApplicationTestBase::TearDown() {
« no previous file with comments | « components/html_viewer/html_viewer.cc ('k') | mojo/application/public/cpp/application_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698