Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: mojo/shell/application_manager.h

Issue 1143793003: Remove application-specific args from Mandoline's shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/application_manager.h
diff --git a/mojo/shell/application_manager.h b/mojo/shell/application_manager.h
index a5ebda31844b7aa7013a67d0f48ed55efbc3ee04..f711a24cc48a64d8f0795ffb3c774bd3c77d9fac 100644
--- a/mojo/shell/application_manager.h
+++ b/mojo/shell/application_manager.h
@@ -154,14 +154,13 @@ class ApplicationManager {
using URLToLoaderMap = std::map<GURL, ApplicationLoader*>;
using URLToNativeOptionsMap = std::map<GURL, NativeRunnerFactory::Options>;
- void ConnectToApplicationWithParameters(
+ void ConnectToApplication(
msw 2015/05/19 17:45:27 Maybe avoid overloading this name with the public
jam 2015/05/19 20:56:37 Done.
const GURL& application_url,
const std::string& qualifier,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services,
- const base::Closure& on_application_end,
- const std::vector<std::string>& pre_redirect_parameters);
+ const base::Closure& on_application_end);
bool ConnectToRunningApplication(const GURL& resolved_url,
const std::string& qualifier,
@@ -177,7 +176,6 @@ class ApplicationManager {
InterfaceRequest<ServiceProvider>* services,
ServiceProviderPtr* exposed_services,
const base::Closure& on_application_end,
- const std::vector<std::string>& parameters,
ApplicationLoader* loader);
InterfaceRequest<Application> RegisterShell(
@@ -186,8 +184,7 @@ class ApplicationManager {
const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services,
- const base::Closure& on_application_end,
- const std::vector<std::string>& parameters);
+ const base::Closure& on_application_end);
ShellImpl* GetShellImpl(const GURL& url, const std::string& qualifier);
@@ -205,7 +202,6 @@ class ApplicationManager {
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services,
const base::Closure& on_application_end,
- const std::vector<std::string>& parameters,
NativeApplicationCleanup cleanup,
scoped_ptr<Fetcher> fetcher);

Powered by Google App Engine
This is Rietveld 408576698