Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: mojo/application/public/cpp/lib/application_impl.cc

Issue 1143793003: Remove application-specific args from Mandoline's shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/application/public/cpp/lib/application_impl.cc
diff --git a/mojo/application/public/cpp/lib/application_impl.cc b/mojo/application/public/cpp/lib/application_impl.cc
index 018729f89bf57f1c957a6a5376e7f14e05ea37ae..53fd8a4f4103615b287f10be50659d534fe13445 100644
--- a/mojo/application/public/cpp/lib/application_impl.cc
+++ b/mojo/application/public/cpp/lib/application_impl.cc
@@ -31,10 +31,6 @@ ApplicationImpl::ApplicationImpl(ApplicationDelegate* delegate,
shell_watch_(nullptr) {
}
-bool ApplicationImpl::HasArg(const std::string& arg) const {
- return std::find(args_.begin(), args_.end(), arg) != args_.end();
-}
-
void ApplicationImpl::ClearConnections() {
for (ServiceRegistryList::iterator i(incoming_service_registries_.begin());
i != incoming_service_registries_.end();
@@ -73,13 +69,11 @@ ApplicationConnection* ApplicationImpl::ConnectToApplication(
}
void ApplicationImpl::Initialize(ShellPtr shell,
- Array<String> args,
const mojo::String& url) {
msw 2015/05/19 17:45:27 nit: fits on line above.
jam 2015/05/19 20:56:37 Done.
shell_ = shell.Pass();
shell_watch_ = new ShellPtrWatcher(this);
shell_.set_error_handler(shell_watch_);
url_ = url;
- args_ = args.To<std::vector<std::string>>();
delegate_->Initialize(this);
}

Powered by Google App Engine
This is Rietveld 408576698