Remove application-specific args from Mandoline's shell.

Remove application-specific args from Mandoline's shell.

These weren't being used.

Committed: https://crrev.com/e8da86fc02e25c65d06742b8fdb107e633ede1e7
Cr-Commit-Position: refs/heads/master@{#330620}

[jam, 2015-05-19 17:03:16]

jam@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2015-05-19 17:45:27]

lgtm with nits and comment.

https://codereview.chromium.org/1143793003/diff/1/components/html_viewer/html...
File components/html_viewer/html_viewer.cc (right):

https://codereview.chromium.org/1143793003/diff/1/components/html_viewer/html...
components/html_viewer/html_viewer.cc:54: const String& url) override {
nit: fits on line above.

https://codereview.chromium.org/1143793003/diff/1/mojo/application/applicatio...
File mojo/application/application_test_base_chromium.cc (right):

https://codereview.chromium.org/1143793003/diff/1/mojo/application/applicatio...
mojo/application/application_test_base_chromium.cc:44: const mojo::String& url)
override {
nit: fits on line above.

https://codereview.chromium.org/1143793003/diff/1/mojo/application/public/cpp...
File mojo/application/public/cpp/application_impl.h (right):

https://codereview.chromium.org/1143793003/diff/1/mojo/application/public/cpp...
mojo/application/public/cpp/application_impl.h:84: const mojo::String& url)
override;
nit: fits on line above.

https://codereview.chromium.org/1143793003/diff/1/mojo/application/public/cpp...
File mojo/application/public/cpp/lib/application_impl.cc (right):

https://codereview.chromium.org/1143793003/diff/1/mojo/application/public/cpp...
mojo/application/public/cpp/lib/application_impl.cc:72: const mojo::String& url)
{
nit: fits on line above.

https://codereview.chromium.org/1143793003/diff/1/mojo/shell/application_mana...
File mojo/shell/application_manager.h (right):

https://codereview.chromium.org/1143793003/diff/1/mojo/shell/application_mana...
mojo/shell/application_manager.h:157: void ConnectToApplication(
Maybe avoid overloading this name with the public ConnectToApplication?

[jam, 2015-05-19 20:56:31]

The CQ bit was checked by jam@chromium.org

[jam, 2015-05-19 20:56:32]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1143793003/#ps20001
(title: "review comments")

[jam, 2015-05-19 20:56:37]

https://codereview.chromium.org/1143793003/diff/1/components/html_viewer/html...
File components/html_viewer/html_viewer.cc (right):

https://codereview.chromium.org/1143793003/diff/1/components/html_viewer/html...
components/html_viewer/html_viewer.cc:54: const String& url) override {
On 2015/05/19 17:45:26, msw wrote:
> nit: fits on line above.

Done.

https://codereview.chromium.org/1143793003/diff/1/mojo/application/applicatio...
File mojo/application/application_test_base_chromium.cc (right):

https://codereview.chromium.org/1143793003/diff/1/mojo/application/applicatio...
mojo/application/application_test_base_chromium.cc:44: const mojo::String& url)
override {
On 2015/05/19 17:45:27, msw wrote:
> nit: fits on line above.

Done.

https://codereview.chromium.org/1143793003/diff/1/mojo/application/public/cpp...
File mojo/application/public/cpp/application_impl.h (right):

https://codereview.chromium.org/1143793003/diff/1/mojo/application/public/cpp...
mojo/application/public/cpp/application_impl.h:84: const mojo::String& url)
override;
On 2015/05/19 17:45:27, msw wrote:
> nit: fits on line above.

Done.

https://codereview.chromium.org/1143793003/diff/1/mojo/application/public/cpp...
File mojo/application/public/cpp/lib/application_impl.cc (right):

https://codereview.chromium.org/1143793003/diff/1/mojo/application/public/cpp...
mojo/application/public/cpp/lib/application_impl.cc:72: const mojo::String& url)
{
On 2015/05/19 17:45:27, msw wrote:
> nit: fits on line above.

Done.

https://codereview.chromium.org/1143793003/diff/1/mojo/shell/application_mana...
File mojo/shell/application_manager.h (right):

https://codereview.chromium.org/1143793003/diff/1/mojo/shell/application_mana...
mojo/shell/application_manager.h:157: void ConnectToApplication(
On 2015/05/19 17:45:27, msw wrote:
> Maybe avoid overloading this name with the public ConnectToApplication?

Done.

[commit-bot: I haz the power, 2015-05-19 20:57:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143793003/20001

[commit-bot: I haz the power, 2015-05-19 21:52:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-19 21:54:02]

Patchset 2 (id:??) landed as
https://crrev.com/e8da86fc02e25c65d06742b8fdb107e633ede1e7
Cr-Commit-Position: refs/heads/master@{#330620}

[Will Harris, 2015-05-19 23:07:25]

On 2015/05/19 21:54:02, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/e8da86fc02e25c65d06742b8fdb107e633ede1e7
> Cr-Commit-Position: refs/heads/master@{#330620}

this appeared to cause a failure on clobber bot -
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/buil...

flake?

[jam, 2015-05-19 23:46:11]

On 2015/05/19 23:07:25, Will Harris wrote:
> On 2015/05/19 21:54:02, I haz the power (commit-bot) wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/e8da86fc02e25c65d06742b8fdb107e633ede1e7
> > Cr-Commit-Position: refs/heads/master@{#330620}
> 
> this appeared to cause a failure on clobber bot -
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/buil...
> 
> flake?

it's a gn target that's only on clobber bot (i.e. not CQ). i'm fixing it now.