Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 114373004: Remove the SVGColor and SVGPaint DOM interfaces (were deprecated). (Closed)

Created:
7 years ago by Erik Dahlström (inactive)
Modified:
7 years ago
CC:
blink-reviews, shans, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, Steve Block, dino_apple.com, rwlbuis, Nils Barth (inactive), jamesr, Nate Chapin, arv+blink, alancutter (OOO until 2018), dstockwell, dsinclair, dglazkov+blink, abarth-chromium, danakj, marja+watch_chromium.org, Timothy Loh, Rik, pdr., Eric Willigers, rjwright, sof, jbroman, krit, darktears, kojih, jsbell+bindings_chromium.org, Mike Lawther (Google), f(malita), Inactive, Stephen Chennney, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the SVGColor and SVGPaint DOM interfaces (were deprecated). Spec: http://www.w3.org/TR/SVG11/svgdom.html#ExtendedInterfaces SVG2 spec removal: https://svgwg.org/svg2-draft/changes.html#svgdom Change test expectations, serialize colors as CSS component values, aka the same way as the 'color' property. Opera (Presto) and Firefox already use that way of serializing SVGColor/SVGPaint values. CSSOM WD spec for serializing <color> values: http://dev.w3.org/csswg/cssom/#serialize-a-css-component-value This is to prepare for rewriting the SVG side, removing the respective classes there too. BUG=329518 R=pdr, krit, schenney Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164179

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 3

Patch Set 3 : review fix #

Patch Set 4 : CRLF fix #

Patch Set 5 : rebased to hopefully fix cr/lf apply_issue fail #

Patch Set 6 : adjust test expectations #

Patch Set 7 : text diff fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+444 lines, -1306 lines) Patch
M LayoutTests/animations/resources/animation-test-helpers.js View 1 chunk +1 line, -9 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt View 5 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 5 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/parse-color-int-or-percent-crash.html View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-properties.js View 5 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 5 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/svg/animations/additive-type-by-animation-expected.txt View 3 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/svg/animations/animate-color-calcMode-discrete-expected.txt View 1 chunk +18 lines, -18 lines 0 comments Download
M LayoutTests/svg/animations/animate-color-fill-currentColor-expected.txt View 1 chunk +9 lines, -18 lines 0 comments Download
M LayoutTests/svg/animations/animate-color-fill-from-by-expected.txt View 1 chunk +9 lines, -18 lines 0 comments Download
M LayoutTests/svg/animations/animate-color-transparent-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/svg/animations/animate-currentColor-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/svg/animations/animate-dynamic-update-attributeName-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/svg/animations/animate-elem-03-t-drt-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/svg/animations/animate-inherit-css-property-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M LayoutTests/svg/animations/attributeTypes-expected.txt View 1 chunk +48 lines, -48 lines 0 comments Download
M LayoutTests/svg/animations/resources/SVGAnimationTestCase.js View 1 chunk +9 lines, -8 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-color-fill-currentColor.js View 3 chunks +0 lines, -9 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-color-fill-from-by.js View 3 chunks +0 lines, -9 lines 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 4 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/svg/css/rect-system-color.xhtml View 2 chunks +12 lines, -8 lines 0 comments Download
M LayoutTests/svg/css/rect-system-color-expected.txt View 1 chunk +168 lines, -168 lines 0 comments Download
M LayoutTests/svg/css/script-tests/svg-attribute-parser-mode.js View 2 chunks +21 lines, -21 lines 0 comments Download
M LayoutTests/svg/css/svg-attribute-parser-mode-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
D LayoutTests/svg/custom/fill-SVGPaint-interface.svg View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/svg/custom/fill-SVGPaint-interface-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M LayoutTests/svg/custom/global-constructors-expected.txt View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/svg/custom/js-svg-constructors.svg View 2 chunks +0 lines, -16 lines 0 comments Download
M LayoutTests/svg/custom/js-svg-constructors-expected.txt View 2 chunks +0 lines, -14 lines 0 comments Download
M LayoutTests/svg/custom/script-tests/global-constructors.js View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D LayoutTests/svg/dom/SVGColor.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/svg/dom/SVGColor-expected.txt View 1 chunk +0 lines, -71 lines 0 comments Download
D LayoutTests/svg/dom/SVGPaint.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/svg/dom/SVGPaint-expected.txt View 1 chunk +0 lines, -244 lines 0 comments Download
M LayoutTests/svg/dom/SVGStyleElement/disable-svg-style-element-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/dom/SVGStyleElement/script-tests/disable-svg-style-element.js View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/svg/dom/rgb-color-parser.html View 1 chunk +2 lines, -7 lines 0 comments Download
M LayoutTests/svg/dom/rgb-color-parser-expected.txt View 3 chunks +12 lines, -12 lines 0 comments Download
D LayoutTests/svg/dom/script-tests/SVGColor.js View 1 chunk +0 lines, -75 lines 0 comments Download
D LayoutTests/svg/dom/script-tests/SVGPaint.js View 1 chunk +0 lines, -227 lines 0 comments Download
M LayoutTests/transitions/svg-transitions-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-fill-interpolation-expected.txt View 5 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-stroke-interpolation-expected.txt View 5 6 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/legacy-animations-engine/transitions/svg-transitions-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 5 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 5 2 chunks +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8CSSValueCustom.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +1 line, -26 lines 0 comments Download
M Source/core/svg/SVGAnimatedType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGColor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/svg/SVGColor.idl View 1 chunk +0 lines, -38 lines 0 comments Download
D Source/core/svg/SVGPaint.idl View 1 chunk +0 lines, -44 lines 0 comments Download
M Source/platform/graphics/Color.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/graphics/Color.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Erik Dahlström (inactive)
7 years ago (2013-12-18 13:30:47 UTC) #1
Stephen Chennney
Just one test that I think needs to have a check removed. Otherwise LGTM. https://codereview.chromium.org/114373004/diff/20001/LayoutTests/svg/custom/global-constructors-expected.txt ...
7 years ago (2013-12-18 13:53:14 UTC) #2
Stephen Chennney
You'll need an LGTM from an owner in this set for the bindings change. Source/bindings/OWNERS ...
7 years ago (2013-12-18 13:55:48 UTC) #3
Erik Dahlström (inactive)
https://codereview.chromium.org/114373004/diff/20001/LayoutTests/svg/custom/global-constructors-expected.txt File LayoutTests/svg/custom/global-constructors-expected.txt (right): https://codereview.chromium.org/114373004/diff/20001/LayoutTests/svg/custom/global-constructors-expected.txt#newcode22 LayoutTests/svg/custom/global-constructors-expected.txt:22: FAIL SVGColor.toString() should be function SVGColor() { [native code] ...
7 years ago (2013-12-18 14:11:58 UTC) #4
haraken
LGTM for bindings/
7 years ago (2013-12-18 15:10:54 UTC) #5
haraken
7 years ago (2013-12-18 15:11:11 UTC) #6
Stephen Chennney
Excellent, except the merge gods are against you. Looks like another rebase before landing.
7 years ago (2013-12-18 15:53:04 UTC) #7
Erik Dahlström (inactive)
On 2013/12/18 15:53:04, Stephen Chenney wrote: > Excellent, except the merge gods are against you. ...
7 years ago (2013-12-18 15:58:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/114373004/110001
7 years ago (2013-12-19 12:47:00 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-19 14:10:51 UTC) #10
Message was sent while issue was closed.
Change committed as 164179

Powered by Google App Engine
This is Rietveld 408576698