Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: LayoutTests/animations/resources/animation-test-helpers.js

Issue 114373004: Remove the SVGColor and SVGPaint DOM interfaces (were deprecated). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: text diff fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/animations/resources/animation-test-helpers.js
diff --git a/LayoutTests/animations/resources/animation-test-helpers.js b/LayoutTests/animations/resources/animation-test-helpers.js
index 0860ff939588b9ff43c632c11b7ed5233de549ed..fcd316fab2091fdc57803bd3d4c02edd0a0b1f53 100644
--- a/LayoutTests/animations/resources/animation-test-helpers.js
+++ b/LayoutTests/animations/resources/animation-test-helpers.js
@@ -317,15 +317,7 @@ function checkExpectedTransitionValue(expected, index)
break;
}
}
- } else if (property == "fill" || property == "stroke") {
- computedValue = window.getComputedStyle(document.getElementById(elementId)).getPropertyCSSValue(property).rgbColor;
- if (compareRGB([computedValue.red.cssText, computedValue.green.cssText, computedValue.blue.cssText], expectedValue, tolerance))
- pass = true;
- else {
- // We failed. Make sure computed value is something we can read in the error message
- computedValue = window.getComputedStyle(document.getElementById(elementId)).getPropertyCSSValue(property).cssText;
- }
- } else if (property == "stop-color" || property == "flood-color" || property == "lighting-color") {
+ } else if (property == "fill" || property == "stroke" || property == "stop-color" || property == "flood-color" || property == "lighting-color") {
computedValue = window.getComputedStyle(document.getElementById(elementId)).getPropertyCSSValue(property);
// The computedValue cssText is rgb(num, num, num)
var components = computedValue.cssText.split("(")[1].split(")")[0].split(",");
« no previous file with comments | « no previous file | LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698