Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: lib/src/options.dart

Issue 1143683002: cleanup: simplify creation of AnalysisContext (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/multi_package_resolver.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index ef4f6d787abb2b32cbaeee3f89e7c5117cbbe8b4..96a72cfd19a745c3b51dc847cf0cd486ea7b7f31 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -14,7 +14,8 @@ import 'package:logging/logging.dart' show Level;
import 'package:path/path.dart' as path;
import 'package:yaml/yaml.dart';
-/// Options used by our TypeResolver.
+/// Options used by our checker.
+// TODO(jmesserly): useMultiPackage/packageRoot don't apply anymore.
vsm 2015/05/18 15:51:16 Don't we still need this for g3?
Jennifer Messerly 2015/05/18 16:24:41 yes, I'll reword. The problem is they are not used
class ResolverOptions {
/// Whether to resolve 'package:' uris using the multi-package resolver.
final bool useMultiPackage;
« no previous file with comments | « lib/src/multi_package_resolver.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698