cleanup: simplify creation of AnalysisContext

lib/src/options.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Set of flags and options passed to the compiler
 library dev_compiler.src.options;
 
 import 'dart:io';
 
 import 'package:args/args.dart';
 import 'package:cli_util/cli_util.dart' show getSdkDir;
 import 'package:dev_compiler/config.dart';
 import 'package:logging/logging.dart' show Level;
 import 'package:path/path.dart' as path;
 import 'package:yaml/yaml.dart';
 
-/// Options used by our TypeResolver.
+/// Options used by our checker.
+// TODO(jmesserly): useMultiPackage/packageRoot don't apply anymore.

[vsm, 2015/05/18 15:51:16]

Don't we still need this for g3?

[Jennifer Messerly, 2015/05/18 16:24:41]

yes, I'll reword. The problem is they are not used by the checker. They should
be in CompilerOptions instead of here.

 class ResolverOptions {
   /// Whether to resolve 'package:' uris using the multi-package resolver.
   final bool useMultiPackage;
 
   /// Package root when resolving 'package:' urls the standard way.
   final String packageRoot;
 
   /// List of paths used for the multi-package resolver.
   final List<String> packagePaths;
 
@@ skipping 417 matching lines @@
     // The pub-cache directory is two levels up, but we verify that the layout
     // looks correct.
     if (path.basename(dir) != 'dev_compiler') return null;
     dir = path.dirname(dir);
     if (path.basename(dir) != 'global_packages') return null;
     dir = path.dirname(dir);
     return path.join(dir, cacheDir, 'lib', 'runtime');
   }
   return null;
 }