Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1143683002: cleanup: simplify creation of AnalysisContext (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cleanup: simplify creation of AnalysisContext removes TypeResolver class, introduces function to create analysis context, simplifies a few other things around mock vs real SDK sources. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/cac1df03dbe18854e1c8df40f783246a9442db37

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -335 lines) Patch
M bin/edit_files.dart View 6 chunks +9 lines, -8 lines 0 comments Download
M lib/devc.dart View 2 chunks +5 lines, -9 lines 0 comments Download
A lib/src/analysis_context.dart View 1 1 chunk +77 lines, -0 lines 0 comments Download
D lib/src/checker/dart_sdk.dart View 1 chunk +0 lines, -163 lines 0 comments Download
D lib/src/checker/multi_package_resolver.dart View 1 chunk +0 lines, -51 lines 0 comments Download
M lib/src/checker/resolver.dart View 1 chunk +0 lines, -74 lines 0 comments Download
A + lib/src/dart_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
A + lib/src/multi_package_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/options.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/testing.dart View 1 3 chunks +9 lines, -16 lines 0 comments Download
M test/dependency_graph_test.dart View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
lgtm https://codereview.chromium.org/1143683002/diff/20001/lib/src/options.dart File lib/src/options.dart (right): https://codereview.chromium.org/1143683002/diff/20001/lib/src/options.dart#newcode18 lib/src/options.dart:18: // TODO(jmesserly): useMultiPackage/packageRoot don't apply anymore. Don't we ...
5 years, 7 months ago (2015-05-18 15:51:16 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/1143683002/diff/20001/lib/src/options.dart File lib/src/options.dart (right): https://codereview.chromium.org/1143683002/diff/20001/lib/src/options.dart#newcode18 lib/src/options.dart:18: // TODO(jmesserly): useMultiPackage/packageRoot don't apply anymore. On 2015/05/18 15:51:16, ...
5 years, 7 months ago (2015-05-18 16:24:42 UTC) #3
Jennifer Messerly
5 years, 7 months ago (2015-05-18 17:20:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
cac1df03dbe18854e1c8df40f783246a9442db37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698