Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1143663003: Disable flaky UnloadTest.CrossSiteInfiniteBeforeUnloadSync on Mac. (Closed)

Created:
5 years, 7 months ago by Charlie Reis
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky UnloadTest.CrossSiteInfiniteBeforeUnloadSync on Mac. BUG=462671 Committed: https://crrev.com/29c5ee3c1de3b1806d838388a69c85fd3e19fde5 Cr-Commit-Position: refs/heads/master@{#330244}

Patch Set 1 #

Patch Set 2 : Disable on all platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/browser/unload_browsertest.cc View 1 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Charlie Reis
Reports on the bug show it's failing on Mac too.
5 years, 7 months ago (2015-05-15 22:53:22 UTC) #2
Lei Zhang
This is effectively disabled on all platforms since mobile platforms don't have browser tests.
5 years, 7 months ago (2015-05-15 23:00:13 UTC) #3
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-15 23:00:17 UTC) #4
Charlie Reis
On 2015/05/15 23:00:13, Lei Zhang wrote: > This is effectively disabled on all platforms since ...
5 years, 7 months ago (2015-05-15 23:04:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143663003/20001
5 years, 7 months ago (2015-05-15 23:09:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-16 00:22:56 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:29:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29c5ee3c1de3b1806d838388a69c85fd3e19fde5
Cr-Commit-Position: refs/heads/master@{#330244}

Powered by Google App Engine
This is Rietveld 408576698