Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6648)

Unified Diff: chrome/browser/unload_browsertest.cc

Issue 1143663003: Disable flaky UnloadTest.CrossSiteInfiniteBeforeUnloadSync on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable on all platforms Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/unload_browsertest.cc
diff --git a/chrome/browser/unload_browsertest.cc b/chrome/browser/unload_browsertest.cc
index c19dc051be47a38be733c1ddbff127ef60f4c9d6..98d50973fd3d4a653c22adc25978dbe4c7300796 100644
--- a/chrome/browser/unload_browsertest.cc
+++ b/chrome/browser/unload_browsertest.cc
@@ -238,15 +238,8 @@ IN_PROC_BROWSER_TEST_F(UnloadTest, CrossSiteInfiniteBeforeUnloadAsync) {
// Navigate to a page with an infinite beforeunload handler.
// Then two two sync crosssite requests to ensure
// we correctly nav to each one.
-// Flaky on Win and Linux; http://crbug.com/462671.
-#if defined(OS_WIN) || defined(OS_LINUX)
-#define MAYBE_CrossSiteInfiniteBeforeUnloadSync \
- DISABLED_CrossSiteInfiniteBeforeUnloadSync
-#else
-#define MAYBE_CrossSiteInfiniteBeforeUnloadSync \
- CrossSiteInfiniteBeforeUnloadSync
-#endif
-IN_PROC_BROWSER_TEST_F(UnloadTest, MAYBE_CrossSiteInfiniteBeforeUnloadSync) {
+// Flaky on Win, Linux, and Mac; http://crbug.com/462671.
+IN_PROC_BROWSER_TEST_F(UnloadTest, DISABLED_CrossSiteInfiniteBeforeUnloadSync) {
// Tests makes no sense in single-process mode since the renderer is hung.
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSingleProcess))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698