Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: chrome/browser/media/router/BUILD.gn

Issue 1143603004: [Media Router] Add Media Router Mojo impl code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed wez's 3rd comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/BUILD.gn
diff --git a/chrome/browser/media/router/BUILD.gn b/chrome/browser/media/router/BUILD.gn
index 62caec66e47829332c000cc87c530e1c6386dff7..1ca91bca2a295121bc87b22694f18785b8474920 100644
--- a/chrome/browser/media/router/BUILD.gn
+++ b/chrome/browser/media/router/BUILD.gn
@@ -10,22 +10,42 @@ gypi_values = exec_script("//build/gypi_to_gn.py",
"scope",
[ "media_router.gypi" ])
-# TODO(mfoltz): Fix problem that requires explicitly listing //skia
source_set("router") {
deps = [
+ ":core",
+ ":keyed_service_factories",
+ ]
+}
+
+# TODO(mfoltz): Fix problem that requires explicitly listing //skia
+source_set("core") {
+ deps = [
":mojo_bindings",
"//base",
+ "//chrome/common:constants",
"//extensions/browser",
"//components/keyed_service/core",
- "//third_party/mojo/src/mojo/public/cpp/bindings",
"//skia",
"//url",
]
- sources = rebase_path(gypi_values.media_router_sources,
+ sources = rebase_path(gypi_values.media_router_core_sources,
".",
"//chrome/browser/media/router")
}
+source_set("keyed_service_factories") {
mark a. foltz 2015/05/26 20:14:29 Why do we need a distinct library here?
imcheng (use chromium acct) 2015/05/26 20:54:03 Last time I tried to put everything into one targe
imcheng (use chromium acct) 2015/05/27 01:06:04 So I recombined the targets and it seems to be wor
+ deps = [
+ ":core",
+ "//components/keyed_service/content",
+ "//extensions/browser",
+ "//third_party/mojo/src/mojo/public/cpp/bindings",
+ ]
+ sources =
+ rebase_path(gypi_values.media_router_keyed_service_factories_sources,
+ ".",
+ "//chrome/browser/media/router")
+}
+
mojom("mojo_bindings") {
sources = [
"media_router.mojom",
@@ -36,7 +56,7 @@ source_set("test_support") {
testonly = true
deps = [
":mojo_bindings",
- ":router",
+ ":core",
mark a. foltz 2015/05/26 20:14:29 It looks like a dependency on :router should be ok
imcheng (use chromium acct) 2015/05/26 20:54:03 ditto
"//chrome/test:test_support",
"//testing/gmock",
]
« no previous file with comments | « no previous file | chrome/browser/media/router/media_router.h » ('j') | chrome/browser/media/router/media_router_mojo_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698