Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: chrome/browser/media/router/BUILD.gn

Issue 1143603004: [Media Router] Add Media Router Mojo impl code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed wez's 3rd comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 # 4 #
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni") 6 import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni")
7 7
8 gypi_values = exec_script("//build/gypi_to_gn.py", 8 gypi_values = exec_script("//build/gypi_to_gn.py",
9 [ rebase_path("media_router.gypi") ], 9 [ rebase_path("media_router.gypi") ],
10 "scope", 10 "scope",
11 [ "media_router.gypi" ]) 11 [ "media_router.gypi" ])
12 12
13 source_set("router") {
14 deps = [
15 ":core",
16 ":keyed_service_factories",
17 ]
18 }
19
13 # TODO(mfoltz): Fix problem that requires explicitly listing //skia 20 # TODO(mfoltz): Fix problem that requires explicitly listing //skia
14 source_set("router") { 21 source_set("core") {
15 deps = [ 22 deps = [
16 ":mojo_bindings", 23 ":mojo_bindings",
17 "//base", 24 "//base",
25 "//chrome/common:constants",
18 "//extensions/browser", 26 "//extensions/browser",
19 "//components/keyed_service/core", 27 "//components/keyed_service/core",
20 "//third_party/mojo/src/mojo/public/cpp/bindings",
21 "//skia", 28 "//skia",
22 "//url", 29 "//url",
23 ] 30 ]
24 sources = rebase_path(gypi_values.media_router_sources, 31 sources = rebase_path(gypi_values.media_router_core_sources,
25 ".", 32 ".",
26 "//chrome/browser/media/router") 33 "//chrome/browser/media/router")
27 } 34 }
28 35
36 source_set("keyed_service_factories") {
mark a. foltz 2015/05/26 20:14:29 Why do we need a distinct library here?
imcheng (use chromium acct) 2015/05/26 20:54:03 Last time I tried to put everything into one targe
imcheng (use chromium acct) 2015/05/27 01:06:04 So I recombined the targets and it seems to be wor
37 deps = [
38 ":core",
39 "//components/keyed_service/content",
40 "//extensions/browser",
41 "//third_party/mojo/src/mojo/public/cpp/bindings",
42 ]
43 sources =
44 rebase_path(gypi_values.media_router_keyed_service_factories_sources,
45 ".",
46 "//chrome/browser/media/router")
47 }
48
29 mojom("mojo_bindings") { 49 mojom("mojo_bindings") {
30 sources = [ 50 sources = [
31 "media_router.mojom", 51 "media_router.mojom",
32 ] 52 ]
33 } 53 }
34 54
35 source_set("test_support") { 55 source_set("test_support") {
36 testonly = true 56 testonly = true
37 deps = [ 57 deps = [
38 ":mojo_bindings", 58 ":mojo_bindings",
39 ":router", 59 ":core",
mark a. foltz 2015/05/26 20:14:29 It looks like a dependency on :router should be ok
imcheng (use chromium acct) 2015/05/26 20:54:03 ditto
40 "//chrome/test:test_support", 60 "//chrome/test:test_support",
41 "//testing/gmock", 61 "//testing/gmock",
42 ] 62 ]
43 sources = rebase_path(gypi_values.media_router_test_support_sources, 63 sources = rebase_path(gypi_values.media_router_test_support_sources,
44 ".", 64 ".",
45 "//chrome/browser/media/router") 65 "//chrome/browser/media/router")
46 } 66 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/media/router/media_router.h » ('j') | chrome/browser/media/router/media_router_mojo_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698