Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1143543002: ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent (1/3). (Closed)

Created:
5 years, 7 months ago by xiang
Modified:
5 years, 5 months ago
Reviewers:
falken, Mike West, jsbell
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Introduce ServiceWorkerMessageEvent to replace MessageEvent(1/3). This's the first CL to make Chrome side CL build. BUG=498596 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M public/platform/WebServiceWorkerProviderClient.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
xiang
PTAL, thanks.
5 years, 7 months ago (2015-05-15 06:00:15 UTC) #2
falken
LGTM
5 years, 6 months ago (2015-06-25 03:50:10 UTC) #3
falken
On 2015/06/25 03:50:10, falken wrote: > LGTM Can you revise the BUG= line of these ...
5 years, 6 months ago (2015-06-25 04:10:53 UTC) #4
xiang
On 2015/06/25 04:10:53, falken wrote: > On 2015/06/25 03:50:10, falken wrote: > > LGTM > ...
5 years, 5 months ago (2015-06-29 02:35:47 UTC) #6
Mike West
LGTM.
5 years, 5 months ago (2015-06-29 07:45:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143543002/1
5 years, 5 months ago (2015-06-29 08:44:31 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 09:49:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197974

Powered by Google App Engine
This is Rietveld 408576698