Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1143473003: Revert of MIPS: Add float instructions and test coverage, part one (Closed)

Created:
5 years, 7 months ago by paul.l...
Modified:
5 years, 7 months ago
Reviewers:
djordje.pesic, balazs.kilvady, dusmil.imgtec, danno, akos.palfi.imgtec
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS: Add float instructions and test coverage, part one Reason for revert: Simulator test failures in RunChangeFloat64ToInt.., RunChangeTaggedToInt32, div-mul-minus-one Original issue's description: > Implement assembler, disassembler tests for all instructions for mips32 > and mips64. Additionally, add missing single precision float instructions > for r2 and r6 architecture variants in assembler, simulator and disassembler > with corresponding tests. BUG= Committed: https://crrev.com/d090469cdd736240f7172696e1f30096695536fc Cr-Commit-Position: refs/heads/master@{#28404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -4229 lines) Patch
M src/mips/assembler-mips.h View 2 chunks +1 line, -20 lines 0 comments Download
M src/mips/assembler-mips.cc View 10 chunks +41 lines, -151 lines 0 comments Download
M src/mips/constants-mips.h View 4 chunks +4 lines, -19 lines 0 comments Download
M src/mips/disasm-mips.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M src/mips/simulator-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/simulator-mips.cc View 9 chunks +35 lines, -490 lines 0 comments Download
M src/mips64/assembler-mips64.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 11 chunks +54 lines, -163 lines 0 comments Download
M src/mips64/constants-mips64.h View 4 chunks +4 lines, -19 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 10 chunks +16 lines, -425 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 13 chunks +56 lines, -1371 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 16 chunks +140 lines, -1340 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 chunk +5 lines, -78 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 1 chunk +2 lines, -76 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
paul.l...
5 years, 7 months ago (2015-05-14 18:15:55 UTC) #2
dusmil.imgtec
Lgtm.
5 years, 7 months ago (2015-05-14 18:18:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143473003/1
5 years, 7 months ago (2015-05-14 18:19:28 UTC) #5
paul.l...
Add author Djordje Pesic to the issue. (I got the wrong name on issue submission)
5 years, 7 months ago (2015-05-14 18:28:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 18:44:56 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 18:45:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d090469cdd736240f7172696e1f30096695536fc
Cr-Commit-Position: refs/heads/master@{#28404}

Powered by Google App Engine
This is Rietveld 408576698