Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1143443002: Use polling to check focused node instead of sleep. (Closed)

Created:
5 years, 7 months ago by bcwhite
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use polling to check focused node instead of sleep. BUG=477632 Committed: https://crrev.com/188e3ae5a5fcf75d937751b62c5e0ade3509b74f Cr-Commit-Position: refs/heads/master@{#329713}

Patch Set 1 #

Patch Set 2 : fixed length comparison #

Total comments: 2

Patch Set 3 : address review comments #

Patch Set 4 : add focus check for another test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 2 3 2 chunks +20 lines, -1 line 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java View 1 2 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
bcwhite
aurimas@chromium.org: Please review changes in ImeTest nyquist@chromium.org: Please review changes in DOMUtils
5 years, 7 months ago (2015-05-13 16:26:45 UTC) #2
nyquist
https://codereview.chromium.org/1143443002/diff/20001/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java File content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java (right): https://codereview.chromium.org/1143443002/diff/20001/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java#newcode158 content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java:158: public static String getFocusedNode(final WebContents webContents) Nit: Unnecessary final. ...
5 years, 7 months ago (2015-05-13 16:50:43 UTC) #3
aurimas (slooooooooow)
ImeTest.java LTGM
5 years, 7 months ago (2015-05-13 17:14:32 UTC) #4
bcwhite
On 2015/05/13 17:14:32, aurimas wrote: > ImeTest.java LTGM Could I get a few letters exchanged...? ...
5 years, 7 months ago (2015-05-13 17:24:28 UTC) #5
aurimas (slooooooooow)
On 2015/05/13 at 17:24:28, bcwhite wrote: > On 2015/05/13 17:14:32, aurimas wrote: > > ImeTest.java ...
5 years, 7 months ago (2015-05-13 17:37:14 UTC) #6
nyquist
lgtm, but I'm no content owner.
5 years, 7 months ago (2015-05-13 17:45:12 UTC) #7
bcwhite
On 2015/05/13 17:45:12, nyquist wrote: > lgtm, but I'm no content owner. You're in content/public/test/android/OWNERS ...
5 years, 7 months ago (2015-05-13 18:19:34 UTC) #8
nyquist
Oh my. No, that's fine. Feel free to go ahead and submit.
5 years, 7 months ago (2015-05-13 20:09:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143443002/60001
5 years, 7 months ago (2015-05-13 20:11:27 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-13 20:54:19 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 20:55:20 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/188e3ae5a5fcf75d937751b62c5e0ade3509b74f
Cr-Commit-Position: refs/heads/master@{#329713}

Powered by Google App Engine
This is Rietveld 408576698