Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 1143443002: Use polling to check focused node instead of sleep. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add focus check for another test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
index d1a21d26565608391b5c25db9e5ae2636fffe64b..d31323398f1453f1b3c9d65a1bb076ef522af0ea 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
@@ -331,7 +331,16 @@ public class ImeTest extends ContentShellTestBase {
assertWaitForKeyboardStatus(false);
DOMUtils.focusNode(mWebContents, "textarea");
assertWaitForKeyboardStatus(true);
- Thread.sleep(50);
+ assertTrue(CriteriaHelper.pollForCriteria(new Criteria() {
+ @Override
+ public boolean isSatisfied() {
+ try {
+ return "textarea".equals(DOMUtils.getFocusedNode(mWebContents));
+ } catch (Exception e) {
+ return false;
+ }
+ }
+ }));
mConnection = (TestAdapterInputConnection) getAdapterInputConnection();
waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 0, "", 0, 0, -1, -1);
@@ -623,6 +632,16 @@ public class ImeTest extends ContentShellTestBase {
assertWaitForKeyboardStatus(false);
DOMUtils.focusNode(mWebContents, "textarea");
assertWaitForKeyboardStatus(true);
+ assertTrue(CriteriaHelper.pollForCriteria(new Criteria() {
+ @Override
+ public boolean isSatisfied() {
+ try {
+ return "textarea".equals(DOMUtils.getFocusedNode(mWebContents));
+ } catch (Exception e) {
+ return false;
+ }
+ }
+ }));
mConnection = (TestAdapterInputConnection) getAdapterInputConnection();
waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 0, "", 0, 0, -1, -1);
« no previous file with comments | « no previous file | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698