Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1143433005: Remove gfx::FrameTime for a single clock source (Closed)

Created:
5 years, 7 months ago by Abhishek Kanike
Modified:
5 years, 7 months ago
CC:
vivekg, Sikugu_, RaviKasibhatla
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gfx::FrameTime for a single clock source A single clock source should be used through out the code. This patch removes the gfx::FrameTime clock and uses the base::TimeTicks overall. BUG=447329 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7215854d64eb300e36bc064f8a987028a650491b Cr-Commit-Position: refs/heads/master@{#331327}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Removing extra spaces #

Patch Set 4 : Clean-up code #

Patch Set 5 : Rebase #

Patch Set 6 : Handling patch for mac files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -136 lines) Patch
M AUTHORS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M cc/input/top_controls_manager.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M cc/input/top_controls_manager_unittest.cc View 1 7 chunks +6 lines, -7 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/begin_frame_args.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/begin_frame_args_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/resource_provider.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/resource_update_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler/begin_frame_source.cc View 3 chunks +2 lines, -3 lines 1 comment Download
M cc/scheduler/scheduler.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/display_scheduler.cc View 1 2 3 4 3 chunks +2 lines, -3 lines 0 comments Download
M cc/test/begin_frame_args_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M cc/tiles/tile_manager_perftest.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 3 chunks +2 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 4 5 chunks +4 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 4 chunks +4 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/aura/overscroll_window_animation_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M ui/compositor/layer_animator.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/compositor/layer_animator_collection.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M ui/compositor/test/layer_animator_test_controller.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M ui/events/gestures/fling_curve_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/animation/animation_container.cc View 4 chunks +3 lines, -5 lines 0 comments Download
D ui/gfx/frame_time.h View 1 chunk +0 lines, -41 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_surface_win.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 32 (13 generated)
r.kasibhatla
https://codereview.chromium.org/1143433005/diff/1/android_webview/browser/hardware_renderer.cc File android_webview/browser/hardware_renderer.cc (right): https://codereview.chromium.org/1143433005/diff/1/android_webview/browser/hardware_renderer.cc#newcode28 android_webview/browser/hardware_renderer.cc:28: Extra line?
5 years, 7 months ago (2015-05-18 12:22:21 UTC) #3
r.kasibhatla
Broadly looks fine. Just remove the extra line added in all files where frame_time.h header ...
5 years, 7 months ago (2015-05-18 12:23:17 UTC) #5
Abhishek Kanike
5 years, 7 months ago (2015-05-22 14:03:12 UTC) #7
Abhishek Kanike
5 years, 7 months ago (2015-05-22 14:10:26 UTC) #8
alex clarke (OOO till 29th)
lgtm LGTM for components/scheduler/renderer/
5 years, 7 months ago (2015-05-22 14:12:37 UTC) #9
alex clarke (OOO till 29th)
lgtm LGTM for components/scheduler/renderer/
5 years, 7 months ago (2015-05-22 14:12:38 UTC) #10
Abhishek Kanike
Reviewers: Danakj - For cc Sadrul - For uievents alexclarke - For components/scheduler Bolui and ...
5 years, 7 months ago (2015-05-22 14:28:03 UTC) #14
Abhishek Kanike
Sorry for spelling your name wrong boliu. On 2015/05/22 14:28:03, Abhishek Kanike wrote: > Reviewers: ...
5 years, 7 months ago (2015-05-22 14:31:08 UTC) #15
boliu
+brianderson who filed the bug
5 years, 7 months ago (2015-05-22 16:18:42 UTC) #17
danakj
brian can review cc
5 years, 7 months ago (2015-05-22 19:12:26 UTC) #19
brianderson
cc lgtm https://codereview.chromium.org/1143433005/diff/100001/cc/scheduler/begin_frame_source.cc File cc/scheduler/begin_frame_source.cc (right): https://codereview.chromium.org/1143433005/diff/100001/cc/scheduler/begin_frame_source.cc#newcode214 cc/scheduler/begin_frame_source.cc:214: time_source = DelayBasedTimeSourceHighRes::Create(initial_vsync_interval, We can also get ...
5 years, 7 months ago (2015-05-22 19:20:56 UTC) #20
boliu
android_webview and content/browser/android/in_process rubberstamp lgtm
5 years, 7 months ago (2015-05-22 20:40:33 UTC) #21
no sievers
content lgtm
5 years, 7 months ago (2015-05-22 22:14:22 UTC) #22
sadrul
lgtm
5 years, 7 months ago (2015-05-25 04:44:47 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143433005/100001
5 years, 7 months ago (2015-05-25 14:40:48 UTC) #25
Abhishek Kanike
On 2015/05/22 19:20:56, brianderson wrote: > cc lgtm > > https://codereview.chromium.org/1143433005/diff/100001/cc/scheduler/begin_frame_source.cc > File cc/scheduler/begin_frame_source.cc (right): ...
5 years, 7 months ago (2015-05-26 06:08:38 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143433005/100001
5 years, 7 months ago (2015-05-26 06:08:56 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-26 06:13:30 UTC) #30
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 06:14:19 UTC) #31
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/7215854d64eb300e36bc064f8a987028a650491b
Cr-Commit-Position: refs/heads/master@{#331327}

Powered by Google App Engine
This is Rietveld 408576698