Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Issue 11434015: Merge 135874 - freeV8NPObject: Skip trying to remove object from per context data's ObjectMap if th… (Closed)

Created:
8 years ago by karen
Modified:
8 years ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 135874 - freeV8NPObject: Skip trying to remove object from per context data's ObjectMap if the object does not exist in the map. https://bugs.webkit.org/show_bug.cgi?id=103356 Patch by Istiaque Ahmed <lazyboy@chromium.org>; on 2012-11-27 Reviewed by Adam Barth. Before introducing per context data, it used to be the case that we would ignore removing v8 object from context data's map if we couldn't find it. With perContextData change, this turned into an ASSERT instead and we had crash reports. Related crbug.com/154462. Source/WebCore: Test: platform/chromium/plugins/release-frame-content-window.html * bindings/v8/NPV8Object.cpp: (WebCore::freeV8NPObject): LayoutTests: * platform/chromium/plugins/release-frame-content-window-expected.txt: Added. * platform/chromium/plugins/release-frame-content-window.html: Added. * platform/chromium/plugins/resources/empty.html: Added. * platform/chromium/plugins/resources/empty2.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
A + LayoutTests/platform/chromium/plugins/release-frame-content-window.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/plugins/release-frame-content-window-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/plugins/resources/empty.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/plugins/resources/empty2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/bindings/v8/NPV8Object.cpp View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years ago (2012-11-28 22:57:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698