Ensure that NSS HTTP IO is initialized on iOS.

net/url_request/url_fetcher_impl_unittest.cc

Index: net/url_request/url_fetcher_impl_unittest.cc
===================================================================
--- net/url_request/url_fetcher_impl_unittest.cc	(revision 168842)
+++ net/url_request/url_fetcher_impl_unittest.cc	(working copy)
@@ -22,7 +22,7 @@
 #include "net/url_request/url_request_throttler_manager.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
 #include "net/ocsp/nss_ocsp.h"
 #endif
 
@@ -111,14 +111,14 @@
 
     io_message_loop_proxy_ = base::MessageLoopProxy::current();
 
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
     crypto::EnsureNSSInit();
     EnsureNSSHttpIOInit();
 #endif
   }
 
   virtual void TearDown() OVERRIDE {
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
     ShutdownNSSHttpIO();
 #endif

[Ryan Sleevi, 2012/11/28 21:56:13]

Broader question: Do we need these at all in the unit test?

This code doesn't make use of any NSS specific functionality. The fact that
SSLClientSocketNSS uses NSS "should be" transparent here to this test.

EnsureNSSSSLInit (called by SSLClientSocketNSS) will ensure that
crypto::EnsureNSSInit is called, and SSLClientSocketNSS will also ensure that
EnsureNSSHttpIOInit() is called on the right thread when starting up.

I can see the argument for calling EnsureNSSHttpIOInit / ShutdownNSSHttpIO as a
general test cleanup, but I think that should be by whatever sets up the
base::MessageLoop for this thread (which I can't seem to find?

[droger, 2012/11/29 08:32:26]

FYI, these tests are excluded on iOS (at the gyp level) because of the test
server. I think we should still try to do the right thing, in case these tests
are enabled in the future.

[wtc, 2012/11/29 19:24:33]

Good question. I haven't found the answer. Because of some
refactoring, it is not easy to research why these two calls
were added in SVN history.
If you find that place, please let me know.

   }