Ensure that NSS HTTP IO is initialized on iOS.

net/url_request/url_fetcher_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_fetcher_impl.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop_proxy.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/thread.h"
 #include "build/build_config.h"
 #include "crypto/nss_util.h"
 #include "net/http/http_response_headers.h"
 #include "net/test/test_server.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_test_util.h"
 #include "net/url_request/url_request_throttler_manager.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
 #include "net/ocsp/nss_ocsp.h"
 #endif
 
 namespace net {
 
 using base::Time;
 using base::TimeDelta;
 
 // TODO(eroman): Add a regression test for http://crbug.com/40505.
 
@@ skipping 68 matching lines @@
   TestURLRequestContext* request_context() {
     return context_.get();
   }
 
  protected:
   virtual void SetUp() OVERRIDE {
     testing::Test::SetUp();
 
     io_message_loop_proxy_ = base::MessageLoopProxy::current();
 
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
     crypto::EnsureNSSInit();
     EnsureNSSHttpIOInit();
 #endif
   }
 
   virtual void TearDown() OVERRIDE {
-#if defined(USE_NSS)
+#if defined(USE_NSS) || defined(OS_IOS)
     ShutdownNSSHttpIO();
 #endif

[Ryan Sleevi, 2012/11/28 21:56:13]

Broader question: Do we need these at all in the unit test?

This code doesn't make use of any NSS specific functionality. The fact that
SSLClientSocketNSS uses NSS "should be" transparent here to this test.

EnsureNSSSSLInit (called by SSLClientSocketNSS) will ensure that
crypto::EnsureNSSInit is called, and SSLClientSocketNSS will also ensure that
EnsureNSSHttpIOInit() is called on the right thread when starting up.

I can see the argument for calling EnsureNSSHttpIOInit / ShutdownNSSHttpIO as a
general test cleanup, but I think that should be by whatever sets up the
base::MessageLoop for this thread (which I can't seem to find?

[droger, 2012/11/29 08:32:26]

FYI, these tests are excluded on iOS (at the gyp level) because of the test
server. I think we should still try to do the right thing, in case these tests
are enabled in the future.

[wtc, 2012/11/29 19:24:33]

Good question. I haven't found the answer. Because of some
refactoring, it is not easy to research why these two calls
were added in SVN history.
If you find that place, please let me know.

   }
 
   // URLFetcher is designed to run on the main UI thread, but in our tests
   // we assume that the current thread is the IO thread where the URLFetcher
   // dispatches its requests to.  When we wish to simulate being used from
   // a UI thread, we dispatch a worker thread to do so.
   scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_;
 
   URLFetcherImpl* fetcher_;
   const scoped_ptr<TestURLRequestContext> context_;
@@ skipping 1111 matching lines @@
   MessageLoop::current()->Run();  // OnURLFetchComplete() will Quit().
 
   MessageLoop::current()->RunUntilIdle();
   ASSERT_FALSE(file_util::PathExists(file_path_))
       << file_path_.value() << " not removed.";
 }
 
 }  // namespace
 
 }  // namespace net