Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 11434004: ash: Refactor some code that snaps windows. (Closed)

Created:
8 years ago by sadrul
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Refactor some code that snaps windows. Introduce SnapSizer::SnapWindow to allow snapping a window on the left/right edges. Use this API in a few places (e.g. from the accelerator controller, gesture handler etc.) BUG=151267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170113

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -64 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 1 chunk +2 lines, -19 lines 0 comments Download
M ash/wm/gestures/system_pinch_handler.cc View 1 1 chunk +3 lines, -12 lines 0 comments Download
M ash/wm/gestures/two_finger_drag_handler.cc View 1 1 chunk +3 lines, -7 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 1 chunk +3 lines, -7 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 1 chunk +24 lines, -18 lines 0 comments Download
M ash/wm/window_util.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/workspace/snap_sizer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/workspace/snap_sizer.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
8 years ago (2012-11-28 19:00:24 UTC) #1
sky
https://codereview.chromium.org/11434004/diff/1/ash/wm/window_util.h File ash/wm/window_util.h (right): https://codereview.chromium.org/11434004/diff/1/ash/wm/window_util.h#newcode89 ash/wm/window_util.h:89: ASH_EXPORT void SnapWindow(aura::Window* window, In hope of not making ...
8 years ago (2012-11-28 22:04:01 UTC) #2
sadrul
https://codereview.chromium.org/11434004/diff/1/ash/wm/window_util.h File ash/wm/window_util.h (right): https://codereview.chromium.org/11434004/diff/1/ash/wm/window_util.h#newcode89 ash/wm/window_util.h:89: ASH_EXPORT void SnapWindow(aura::Window* window, On 2012/11/28 22:04:01, sky wrote: ...
8 years ago (2012-11-28 23:20:16 UTC) #3
sky
8 years ago (2012-11-28 23:38:31 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698